Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 dependencies to requirements-dev.txt file #1084

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Add flake8 dependencies to requirements-dev.txt file #1084

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06a1f8e
add flake8 dependencies to requirements-dev.txt file
dorothykiz1 Mar 3, 2022
16dcde8
add flake8 dependencies to requirements-dev.txt file
dorothykiz1 Mar 3, 2022
c921670
add flake8 dependencies to requirements-dev.txt file
dorothykiz1 Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,8 @@ pytest-faulthandler<2.0; platform_python_implementation == "PyPy"
pytest-timeout
feedparser
python-hglib
flake8==4.0.1
pyflakes==2.4.0
mccabe==0.6.1
pycodestyle==2.8.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the reasoning here, but we want just the latest version of flake8 (the latest at every time, not the latest now), and no other dependencies. If flake8 needs those other packages, they'll be installed automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @datapythonista

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing, but better to not introduce arbitrary blank lines, and keep our changes to exactly what we want.