Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 dependencies to requirements-dev.txt file #1084

Merged
merged 3 commits into from
Mar 3, 2022

Conversation

dorothykiz1
Copy link
Contributor

@dorothykiz1 dorothykiz1 commented Mar 3, 2022

closes #1074

Comment on lines 22 to 25
pyflakes==2.4.0
mccabe==0.6.1
pycodestyle==2.8.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the reasoning here, but we want just the latest version of flake8 (the latest at every time, not the latest now), and no other dependencies. If flake8 needs those other packages, they'll be installed automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -18,3 +18,5 @@ pytest-faulthandler<2.0; platform_python_implementation == "PyPy"
pytest-timeout
feedparser
python-hglib
flake8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing, but better to not introduce arbitrary blank lines, and keep our changes to exactly what we want.

@datapythonista
Copy link
Member

closes [#1074 ]

The squared brackets around the issue will prevent the issue from being automatically closed when this PR is merged. Not sure what are the exact idioms that GitHub accepts, but Closes #1074 surely work (I think closes #1074, Close #1074... are also fine). I think GitHub shows you if you hover after that text, whether this is really going to close the issue or not.

@dorothykiz1
Copy link
Contributor Author

Thank you @datapythonista i didn't know the hovering gives you a clue of what closes will do.

@datapythonista datapythonista merged commit 0af5f71 into airspeed-velocity:master Mar 3, 2022
@datapythonista
Copy link
Member

Thanks @dorothykiz1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flake8 to the dependencies
2 participants