-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake8 dependencies to requirements-dev.txt file #1084
Add flake8 dependencies to requirements-dev.txt file #1084
Conversation
requirements-dev.txt
Outdated
pyflakes==2.4.0 | ||
mccabe==0.6.1 | ||
pycodestyle==2.8.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what's the reasoning here, but we want just the latest version of flake8
(the latest at every time, not the latest now), and no other dependencies. If flake8
needs those other packages, they'll be installed automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @datapythonista
requirements-dev.txt
Outdated
@@ -18,3 +18,5 @@ pytest-faulthandler<2.0; platform_python_implementation == "PyPy" | |||
pytest-timeout | |||
feedparser | |||
python-hglib | |||
flake8 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing, but better to not introduce arbitrary blank lines, and keep our changes to exactly what we want.
The squared brackets around the issue will prevent the issue from being automatically closed when this PR is merged. Not sure what are the exact idioms that GitHub accepts, but |
Thank you @datapythonista i didn't know the hovering gives you a clue of what |
Thanks @dorothykiz1 |
closes #1074