Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Microsoft Sharepoint: Make refresh token optional #37372

Merged
merged 7 commits into from
Apr 24, 2024
Merged

✨ Source Microsoft Sharepoint: Make refresh token optional #37372

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa0e1cc
Add grant type `client_credentials`
tolik0 Apr 17, 2024
34c3ef1
Update version
tolik0 Apr 17, 2024
6a9da2e
Fix docs
tolik0 Apr 17, 2024
6d72936
Delete grant type and make refresh token optional
tolik0 Apr 18, 2024
6c3a26b
Fix docs
tolik0 Apr 18, 2024
1e0ff8e
Add skip of some steps for application authentication flow
tolik0 Apr 19, 2024
3472c0c
Add unit tests
tolik0 Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-microsoft-sharepoint/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ data:
connectorSubtype: file
connectorType: source
definitionId: 59353119-f0f2-4e5a-a8ba-15d887bc34f6
dockerImageTag: 0.2.2
dockerImageTag: 0.2.3
dockerRepository: airbyte/source-microsoft-sharepoint
githubIssueLabel: source-microsoft-sharepoint
icon: microsoft-sharepoint.svg
Expand Down
925 changes: 499 additions & 426 deletions airbyte-integrations/connectors/source-microsoft-sharepoint/poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-microsoft-sharepoint/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "0.2.2"
version = "0.2.3"
name = "source-microsoft-sharepoint"
description = "Source implementation for Microsoft SharePoint."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand Down
5 changes: 4 additions & 1 deletion ...integrations/connectors/source-microsoft-sharepoint/source_microsoft_sharepoint/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ def spec(self, *args: Any, **kwargs: Any) -> ConnectorSpecification:
oauth_user_input_from_connector_config_specification={
"type": "object",
"additionalProperties": False,
"properties": {"tenant_id": {"type": "string", "path_in_connector_config": ["credentials", "tenant_id"]}},
"properties": {
"tenant_id": {"type": "string", "path_in_connector_config": ["credentials", "tenant_id"]},
"grant_type": {"type": "string", "path_in_connector_config": ["credentials", "grant_type"]},
},
},
),
),
Expand Down
7 changes: 7 additions & 0 deletions ...e-integrations/connectors/source-microsoft-sharepoint/source_microsoft_sharepoint/spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ class Config:

# Fields for the OAuth authentication, including tenant_id, client_id, client_secret, and refresh_token
auth_type: Literal["Client"] = Field("Client", const=True)
grant_type: str = Field(
title="OAuth Type",
description="Specifies the location(s) to search for files. Valid options are 'ACCESSIBLE_DRIVES' for all SharePoint drives the user can access, 'SHARED_ITEMS' for shared items the user has access to, and 'ALL' to search both.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update description and
add more details to docs about authentication options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

default="authorization_code",
enum=["authorization_code", "client_credentials"],
)

tenant_id: str = Field(title="Tenant ID", description="Tenant ID of the Microsoft SharePoint user", airbyte_secret=True)
client_id: str = Field(
title="Client ID",
Expand Down
13 changes: 7 additions & 6 deletions docs/integrations/sources/microsoft-sharepoint.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,11 +129,12 @@ The connector is restricted by normal Microsoft Graph [requests limitation](http

## Changelog

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:--------------------------|
| 0.2.2 | 2024-03-28 | [36573](https://github.com/airbytehq/airbyte/pull/36573) | Update QL to 400 |
| 0.2.1 | 2024-03-22 | [36381](https://github.com/airbytehq/airbyte/pull/36381) | Unpin CDK |
| 0.2.0 | 2024-03-06 | [35830](https://github.com/airbytehq/airbyte/pull/35830) | Add fetching shared items |
| 0.1.0 | 2024-01-25 | [33537](https://github.com/airbytehq/airbyte/pull/33537) | New source |
| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------|
| 0.2.3 | 2024-04-17 | [37372](https://github.com/airbytehq/airbyte/pull/37372) | Add grant-type `client_credentials` For OAuth2 Flow |
| 0.2.2 | 2024-03-28 | [36573](https://github.com/airbytehq/airbyte/pull/36573) | Update QL to 400 |
| 0.2.1 | 2024-03-22 | [36381](https://github.com/airbytehq/airbyte/pull/36381) | Unpin CDK |
| 0.2.0 | 2024-03-06 | [35830](https://github.com/airbytehq/airbyte/pull/35830) | Add fetching shared items |
| 0.1.0 | 2024-01-25 | [33537](https://github.com/airbytehq/airbyte/pull/33537) | New source |

</HideInUI>
Loading