✨ Source Microsoft Sharepoint: Make refresh token optional #37372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
connectors/source/microsoft-sharepoint
area/documentation
artem1205
requested changes
Apr 17, 2024
| @@ -21,6 +21,13 @@ class Config: | |||
|
|
|||
| # Fields for the OAuth authentication, including tenant_id, client_id, client_secret, and refresh_token | |||
| auth_type: Literal["Client"] = Field("Client", const=True) | |||
| grant_type: str = Field( | |||
| title="OAuth Type", | |||
| description="Specifies the location(s) to search for files. Valid options are 'ACCESSIBLE_DRIVES' for all SharePoint drives the user can access, 'SHARED_ITEMS' for shared items the user has access to, and 'ALL' to search both.", | |||
There was a problem hiding this comment.
Please update description and
add more details to docs about authentication options.
lazebnyi
reviewed
Apr 18, 2024
| @@ -27,7 +27,7 @@ This page contains the setup guide and reference information for the Microsoft S | |||
| 5. Enter **Drive Name**. To find your drive name go to settings and at the top of setting menu you can find the name of your drive. | |||
| 6. Select **Search Scope**. Specifies the location(s) to search for files. Valid options are 'ACCESSIBLE_DRIVES' for all SharePoint drives the user can access, 'SHARED_ITEMS' for shared items the user has access to, and 'ALL' to search both. Default value is 'ALL'. | |||
| 7. Enter **Folder Path**. Leave empty to search all folders of the drives. This does not apply to shared items. | |||
| 8. The **OAuth2.0** authorization method is selected by default. Click **Authenticate your Microsoft SharePoint account**. Log in and authorize your Microsoft account. | |||
| 8. The **OAuth2.0** authorization is selected by default for authentication. You have the option to choose the `grant_type`: `authorization_code`, which uses a refresh token to maintain access without frequent re-authorizations, or `client_credentials`, which does not require a refresh token. After selecting the desired grant type, click **Authenticate your Microsoft SharePoint account**, log in, and authorize your Microsoft account to connect it with Airbyte. | |||
There was a problem hiding this comment.
is it tested manually?
I think we hide all logic in the UI by one button and all data inputs from DB
There was a problem hiding this comment.
Yes, I tested it locally.
tolik0
changed the title
client_credentials for OAuth2 flow
artem1205
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This update introduces the optionality of the
refresh_tokenparameter in our OAuth flow configurations. This change allows the implementation of OAuth flows without requiring a refresh token, addressing the needs outlined in #35588.How
The modification enables the connector to recognize and appropriately handle cases where the
refresh_tokenis omitted from the OAuth configuration. This facilitates more versatile authentication strategies by supporting differentgrant_typeselections based on the presence or absence of therefresh_token.