Make LottieAnimationView reusable #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngsilverman
commented
Nov 7, 2016
| try { | ||
| adapter.setFiles(getContext().getAssets().list("")); | ||
| adapter.setFiles(AssetUtils.getJsonAssets(getContext(), "")); |
There was a problem hiding this comment.
Directories were appearing in the list and caused a crash when tapped, so this filters out any non-json assets.
ngsilverman
force-pushed
the
nsilverman-reusable-lottieanimationview
branch
2 times, most recently
from
971eb1b
to
2b5468b
Compare
gpeal
reviewed
Nov 7, 2016
| @@ -163,34 +167,54 @@ protected void onDetachedFromWindow() { | |||
| public void recycleBitmaps() { | |||
| if (mainBitmap != null) { | |||
| mainBitmap.recycle(); | |||
| mainBitmap = null; | |||
| @@ -260,16 +293,30 @@ private void setJsonSync(JSONObject json) { | |||
| setComposition(composition); | |||
| } | |||
|
|
|||
| private void onAnimationLoadingFail() { | |||
| isAnimationLoading = false; | |||
There was a problem hiding this comment.
Maybe set playAnimationWhenCompositionSet to false?
There was a problem hiding this comment.
Good point. Done.
ngsilverman
force-pushed
the
nsilverman-reusable-lottieanimationview
branch
from
2b5468b
to
0eca9b5
Compare
gpeal
approved these changes
Nov 7, 2016
Closed
Edward601
suggested changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
Cycleto the sample app that cycles through all the available animation using the sameLottieAnimationView.