Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate loop argument to AIOKafkaConsumer/AIOKafkaProducer #699

Merged
merged 2 commits into from
Dec 21, 2020

Conversation

ods
Copy link
Collaborator

@ods ods commented Dec 17, 2020

Changes

Related to issue #689 and MR #694

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #699 (db070f5) into master (306ae6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #699   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files          29       29           
  Lines        5207     5209    +2     
=======================================
+ Hits         5103     5105    +2     
  Misses        104      104           
Flag Coverage Δ
cext 87.71% <100.00%> (+<0.01%) ⬆️
integration 97.96% <100.00%> (+<0.01%) ⬆️
purepy 97.48% <100.00%> (-0.04%) ⬇️
unit 51.50% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiokafka/consumer/consumer.py 97.91% <100.00%> (+<0.01%) ⬆️
aiokafka/producer/producer.py 98.50% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306ae6e...db070f5. Read the comment docs.

@tvoinarovskyi
Copy link
Member

lgtm

@ods ods merged commit 5d9af4d into aio-libs:master Dec 21, 2020
@ods ods deleted the deprecate_loop branch December 21, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants