-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initialization without running loop (issue #689) #694
Conversation
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 29 29
Lines 5193 5193
=======================================
Hits 5085 5085
Misses 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging 0ef36d7 into 07e9bd3 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, looks great! |
This pull request fixes 1 alert when merging 28dca05 into 4fbea5c - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging ffd1526 into 4fbea5c - view on LGTM.com fixed alerts:
|
Changes
Return (temporary?) back an ability to instantiate
AIOKafkaConsumer
andAIOKafkaProducer
without running loop by passing it explicitly. Fixes #689Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.