Fix initialization without running loop (issue #689) #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 29 29
Lines 5193 5193
=======================================
Hits 5085 5085
Misses 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
This pull request fixes 1 alert when merging 0ef36d7 into 07e9bd3 - view on LGTM.com fixed alerts:
|
|
Thanks, looks great! |
|
This pull request fixes 1 alert when merging 28dca05 into 4fbea5c - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging ffd1526 into 4fbea5c - view on LGTM.com fixed alerts:
|
tvoinarovskyi
approved these changes
Dec 11, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Return (temporary?) back an ability to instantiate
AIOKafkaConsumerandAIOKafkaProducerwithout running loop by passing it explicitly. Fixes #689Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.