[PR #9822/249df6e backport][3.11] Improve performance of the access logger when its disabled

[bdraco]

(cherry picked from commit 249df6e)

[codspeed-hq]

CodSpeed Performance Report

Merging #9828 will not alter performance

_{Comparing patchback/backports/3.11/249df6e1599db75a94dc95f63c498545358f6ef8/pr-9822 (0c5c55c) with 3.11 (6894d4e)}

Summary

✅ 20 untouched benchmarks

[bdraco]

That import time test is still flakey

FAILED tests/test_imports.py::test_import_time - assert 257 < 250

[Dreamsorcerer]

That import time test is still flakey

FAILED tests/test_imports.py::test_import_time - assert 257 < 250

Still looks like 3.12+ as well. Do you think codspeed could handle an import time test? Would be more reliable if we can move it to there instead of CI workers.

[bdraco]

That import time test is still flakey
FAILED tests/test_imports.py::test_import_time - assert 257 < 250

Still looks like 3.12+ as well. Do you think codspeed could handle an import time test? Would be more reliable if we can move it to there instead of CI workers.

It won't work with codspeed because we have to spawn a subprocess. I suspect we have an actual problem to fix as a result of a change of some dep that has pushed it over the edge.

[bdraco]

Profile by time spent in files...

[bdraco]

I don't see any module that is specific or opportunities to optimize. It looks like we are simply on the edge of the number and its time to bump it up

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (6894d4e) to head (0c5c55c).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             3.11    #9828   +/-   ##
=======================================
  Coverage   97.97%   97.98%           
=======================================
  Files         119      119           
  Lines       36170    36191   +21     
  Branches     4334     4336    +2     
=======================================
+ Hits        35439    35461   +22     
  Misses        546      546           
+ Partials      185      184    -1     

Flag	Coverage Δ
CI-GHA	97.87% <100.00%> (+<0.01%)	⬆️
OS-Linux	97.56% <100.00%> (+<0.01%)	⬆️
OS-Windows	94.40% <100.00%> (+<0.01%)	⬆️
OS-macOS	96.67% <100.00%> (+<0.01%)	⬆️
Py-3.10.11	96.52% <100.00%> (+<0.01%)	⬆️
Py-3.10.15	97.07% <100.00%> (-0.05%)	⬇️
Py-3.11.10	96.45% <100.00%> (-0.69%)	⬇️
Py-3.11.9	96.30% <100.00%> (-0.30%)	⬇️
Py-3.12.7	96.96% <100.00%> (-0.69%)	⬇️
Py-3.13.0	97.60% <100.00%> (-0.02%)	⬇️
Py-3.9.13	96.45% <100.00%> (+<0.01%)	⬆️
Py-3.9.20	96.99% <100.00%> (-0.03%)	⬇️
Py-pypy7.3.16	96.60% <100.00%> (-0.01%)	⬇️
VM-macos	96.67% <100.00%> (+<0.01%)	⬆️
VM-ubuntu	97.56% <100.00%> (+<0.01%)	⬆️
VM-windows	94.40% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.