Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8676/2915102 backport][3.10] Fix type ignore in SSLContext creation connector test #8677

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 10, 2024

(cherry picked from commit 2915102)

@bdraco bdraco changed the title Fix type ignore in SSLContext creation connector test (#8676) [PR #8676/2915102 backport][3.10] Fix type ignore in SSLContext creation connector test Aug 10, 2024
@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Aug 10, 2024
@bdraco bdraco marked this pull request as ready for review August 10, 2024 16:15
@bdraco bdraco requested a review from asvetlov as a code owner August 10, 2024 16:15
@bdraco bdraco enabled auto-merge (squash) August 10, 2024 16:15
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (f3fcba4) to head (424f682).
Report is 202 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8677   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files         108      108           
  Lines       34015    34015           
  Branches     4047     4047           
=======================================
  Hits        33241    33241           
  Misses        577      577           
  Partials      197      197           
Flag Coverage Δ
CI-GHA 97.62% <100.00%> (ø)
OS-Linux 97.30% <100.00%> (ø)
OS-Windows 94.82% <100.00%> (ø)
OS-macOS 96.96% <100.00%> (ø)
Py-3.10.11 97.06% <100.00%> (ø)
Py-3.10.14 97.01% <100.00%> (ø)
Py-3.11.9 97.25% <100.00%> (ø)
Py-3.12.4 97.35% <100.00%> (ø)
Py-3.8.10 94.43% <100.00%> (ø)
Py-3.8.18 96.79% <100.00%> (ø)
Py-3.9.13 96.94% <100.00%> (ø)
Py-3.9.19 96.90% <100.00%> (ø)
Py-pypy7.3.16 96.49% <100.00%> (ø)
VM-macos 96.96% <100.00%> (ø)
VM-ubuntu 97.30% <100.00%> (ø)
VM-windows 94.82% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 73d17d4 into 3.10 Aug 10, 2024
31 of 32 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/29151021f957a524f612e9effc20ede8538195ab/pr-8676 branch August 10, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant