-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type ignore in SSLContext creation connector test #8676
Conversation
With a little tweak to the pytest parametrize API that could probably be caught as a type error in the function signature/decorator... 🤔️ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8676 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 107 107
Lines 33825 33825
Branches 3969 3969
=======================================
Hits 33143 33143
Misses 505 505
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2915102 on top of patchback/backports/3.10/29151021f957a524f612e9effc20ede8538195ab/pr-8676 Backporting merged PR #8676 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2915102 on top of patchback/backports/3.11/29151021f957a524f612e9effc20ede8538195ab/pr-8676 Backporting merged PR #8676 into master
🤖 @patchback |
(cherry picked from commit 2915102)
(cherry picked from commit 2915102)
Fixes the typing in
test_ssl_context_creation_raises
. This is not a runtime change.#8672 (comment)