Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable lockbot comments and add notes in the contribution docs #4508

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Disable lockbot comments and add notes in the contribution docs #4508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
814505d
Disable lockbot comments and add notes in the contribution docs
achimnol Jan 17, 2020
18c7920
Minor fix: PR is also locked
achimnol Jan 17, 2020
4e55d70
Add changelog
achimnol Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/lock.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,7 @@ exemptLabels: []
lockLabel: outdated

# Comment to post before locking. Set to `false` to disable
lockComment: |
This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a [new issue] for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that [new issue].

[new issue]: https://github.com/aio-libs/aiohttp/issues/new
lockComment: false

# Assign `resolved` as the reason for locking. Set to `false` to disable
setLockReason: true
Expand Down
1 change: 1 addition & 0 deletions CHANGES/4504.doc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Updated the contribution guide to reflect the automatic thread locking policy.
10 changes: 10 additions & 0 deletions docs/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,16 @@ Workflow is pretty straightforward:
needed. The Pull Request is automatically squashed into the single commit
once the PR is accepted.

.. note::

GitHub issue and pull request threads are automatically locked when there has
not been any recent activity for one year. Please open a `new issue
<https://github.com/aio-libs/aiohttp/issues/new>`_ for related bugs.

If you feel like there are important points in the locked discussions,
please include those exceprts into that new issue.


Preconditions for running aiohttp test suite
--------------------------------------------

Expand Down