Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable lockbot comments and add notes in the contribution docs #4508

Merged
merged 3 commits into from
Jan 17, 2020

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Jan 17, 2020

What do these changes do?

Disables automatic comments by the lockbot to reduce notification spams along with a new note in the contribution guideline documentation.

Are there changes in behavior for the user?

No code changes.

Related issue number

#4504

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 17, 2020
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #4508 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4508   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          43       43           
  Lines        8865     8865           
  Branches     1390     1390           
=======================================
  Hits         8645     8645           
  Misses         96       96           
  Partials      124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8218fd0...4e55d70. Read the comment docs.

@asvetlov asvetlov merged commit 6d2b136 into aio-libs:master Jan 17, 2020
@asvetlov
Copy link
Member

Thanks!

@achimnol achimnol deleted the maintenace/lockbot-config branch January 19, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants