Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Tune mlflow converter run properties #2134

Merged
merged 3 commits into from
Sep 1, 2022
Merged

[feat] Tune mlflow converter run properties #2134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4612cef
[feat] Tune mlflow converter run properties
tamohannes Sep 1, 2022
431e211
Merge branch 'release/3.13.x' into feature/tune-mlflow-converter-run-…
mihran113 Sep 1, 2022
1eebedf
Update changelog
mihran113 Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Fix aim reindex command failure (alberttorosyan)
- Fix issue with remote runs re-open (mihran113)
- Deprecate custom set Run.hash values (alberttorosyan)
- Tune mlflow converter run properties (tmynn)

## 3.13.0 Aug 21, 2022

Expand Down
8 changes: 5 additions & 3 deletions aim/cli/convert/processors/mlflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,18 @@ def parse_mlflow_logs(repo_inst, tracking_uri, experiment):
aim_run = Run(
repo=repo_inst,
system_tracking_interval=None,
run_hash=run.info.run_uuid,
capture_terminal_logs=False,
experiment=ex.experiment_id,
)
aim_run['mlflow_run_id'] = run.info.run_id
aim_run['mlflow_run_name'] = run.data.tags.get("mlflow.runName")
aim_run.description = run.data.tags.get("mlflow.note.content")

# Collect params & tags
aim_run['params'] = run.data.params
aim_run['tags'] = {
k: v for k, v in run.data.tags.items() if not k.startswith('mlflow')
}
aim_run['description'] = run.data.tags.get("mlflow.note.content")

# Collect metrics
for key in run.data.metrics.keys():
Expand All @@ -79,7 +81,7 @@ def parse_mlflow_logs(repo_inst, tracking_uri, experiment):

# Collect artifacts
__html_warning_issued = False
with TemporaryDirectory(prefix=f'mlflow_{run.info.run_uuid}_') as temp_path:
with TemporaryDirectory(prefix=f'mlflow_{run.info.run_id}_') as temp_path:
# click.secho(f'Downloading artifacts to {temp_path}', fg='green')
artifact_loc_stack = [None]
while artifact_loc_stack:
Expand Down