Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Tune mlflow converter run properties #2134

Merged
merged 3 commits into from
Sep 1, 2022
Merged

[feat] Tune mlflow converter run properties #2134

merged 3 commits into from
Sep 1, 2022

Conversation

tamohannes
Copy link
Contributor

@tamohannes tamohannes commented Sep 1, 2022 •
edited
Loading

Changed the way of getting mlflow run id. Added the run_name and the description.

@tamohannes tamohannes self-assigned this Sep 1, 2022
alberttorosyan
alberttorosyan approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmynn please update the CHANGELOG.md
the rest looks good

gorarakelyan
gorarakelyan approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@gorarakelyan gorarakelyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mihran113 mihran113 merged commit faa11c4 into release/3.13.x Sep 1, 2022
@mihran113 mihran113 deleted the feature/tune-mlflow-converter-run-props-2 branch September 1, 2022 17:14
@tamohannes
Copy link
Contributor Author

Resolves #2151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihran113 mihran113 mihran113 approved these changes

@gorarakelyan gorarakelyan gorarakelyan approved these changes

@alberttorosyan alberttorosyan alberttorosyan approved these changes

Assignees

@tamohannes tamohannes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tamohannes @mihran113 @gorarakelyan @alberttorosyan