Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor property #298

Merged
merged 3 commits into from
Sep 8, 2024
Merged

refactor property #298

merged 3 commits into from
Sep 8, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 8, 2024

Follow up #297 .

Also add StructureData property

@superstar54 superstar54 changed the title refactor property, add StructureData refactor property Sep 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 78.43137% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.80%. Comparing base (5937b88) to head (518de19).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/properties/builtins.py 70.31% 19 Missing ⚠️
aiida_workgraph/utils/__init__.py 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
+ Coverage   75.75%   80.80%   +5.05%     
==========================================
  Files          70       65       -5     
  Lines        4615     4892     +277     
==========================================
+ Hits         3496     3953     +457     
+ Misses       1119      939     -180     
Flag Coverage Δ
python-3.11 80.70% <78.43%> (+5.03%) ⬆️
python-3.12 80.72% <78.43%> (?)
python-3.9 80.74% <78.43%> (+5.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 3e1b35d into main Sep 8, 2024
8 checks passed
@superstar54 superstar54 deleted the refactor_properties branch September 8, 2024 08:10
GeigerJ2 pushed a commit to GeigerJ2/aiida-workgraph that referenced this pull request Sep 13, 2024
* refactor property, add StructureData
* Update validate for property, and update the test
GeigerJ2 added a commit to GeigerJ2/aiida-workgraph that referenced this pull request Sep 13, 2024
* refactor property, add StructureData
* Update validate for property, and update the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants