Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove property class from node-graph #297

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 7, 2024

Follow #294, this PR removes all property types from node-graph.

Note this PR can not guarantee that the property works properly. We need future PR to refactor the property class.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (5937b88) to head (9ec5ce9).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
aiida_workgraph/properties/builtins.py 68.75% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   75.75%   79.89%   +4.14%     
==========================================
  Files          70       65       -5     
  Lines        4615     5014     +399     
==========================================
+ Hits         3496     4006     +510     
+ Misses       1119     1008     -111     
Flag Coverage Δ
python-3.11 79.81% <75.00%> (+4.15%) ⬆️
python-3.12 79.81% <75.00%> (?)
python-3.9 79.85% <75.00%> (+4.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit d623fb1 into main Sep 7, 2024
8 checks passed
@superstar54 superstar54 deleted the fix/remove_node_graph_property branch September 7, 2024 14:59
@superstar54 superstar54 mentioned this pull request Sep 8, 2024
GeigerJ2 pushed a commit to GeigerJ2/aiida-workgraph that referenced this pull request Sep 13, 2024
GeigerJ2 added a commit to GeigerJ2/aiida-workgraph that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants