Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 IMPROVE: MultipleEntryPointError message #5074

Merged
merged 1 commit into from
Aug 12, 2021
Merged

👌 IMPROVE: MultipleEntryPointError message #5074

merged 1 commit into from
Aug 12, 2021

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Aug 12, 2021

Include the actual entry-points object in the exception message,
to allow debugging of what packages are causing the clash.

fixes #696

for example, an error message would be:

MultipleEntryPointError: Multiple entry points 'name' found in group 'aiida.groups': (EntryPoint(name='name', value='aiida.orm.groups:Group', group='aiida.groups'), EntryPoint(name='name', value='other.groups:Group', group='aiida.groups'))

Include the actual entry-points object in the exception message.

closes #696
@sphuber
Copy link
Contributor

sphuber commented Aug 12, 2021

Uh-oh, trouble in paradise? Did you actually encounter this locally? Any sign of a problem with the switch from reentry to importlib_metadata?

@chrisjsewell
Copy link
Member Author

chrisjsewell commented Aug 12, 2021

h-oh, trouble in paradise? Did you actually encounter this locally?

Oh no, nothing like that; was just searching the issues for any related to reentry which could now be closed

(see also #3919, #4455)

@sphuber sphuber merged commit fa498bc into develop Aug 12, 2021
@sphuber sphuber deleted the fix/#696 branch August 12, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AiiDA should output a helpful error message when plugin entrypoints clash
2 participants