Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group error message needs to contain instructions on what to do #3919

Closed
ltalirz opened this issue Apr 9, 2020 · 4 comments · Fixed by #5076
Closed

group error message needs to contain instructions on what to do #3919

ltalirz opened this issue Apr 9, 2020 · 4 comments · Fixed by #5076
Assignees

Comments

@ltalirz
Copy link
Member

ltalirz commented Apr 9, 2020

On the latest develop branch, I now get this error message

-/Users/leopold/Personal/Postdoc-MARVEL/repos/aiida/aiida_rmq/aiida/orm/groups.py:61: UserWarning: no registered entry point for `Group` so its instances will not be storable.
  warnings.warn(message)  # pylint: disable=no-member
/Users/leopold/Personal/Postdoc-MARVEL/repos/aiida/aiida_rmq/aiida/orm/groups.py:61: UserWarning: no registered entry point for `AutoGroup` so its instances will not be storable.
  warnings.warn(message)  # pylint: disable=no-member
/Users/leopold/Personal/Postdoc-MARVEL/repos/aiida/aiida_rmq/aiida/orm/groups.py:61: UserWarning: no registered entry point for `ImportGroup` so its instances will not be storable.
  warnings.warn(message)  # pylint: disable=no-member
/Users/leopold/Personal/Postdoc-MARVEL/repos/aiida/aiida_rmq/aiida/orm/groups.py:61: UserWarning: no registered entry point for `UpfFamily` so its instances will not be storable.
  warnings.warn(message)  # pylint: disable=no-member

and if I understand correctly, essentially all AiiDA users will get those when they upgrade.

In order to save us from tons of questions, we really need to put instructions into this warning on how to make it go away again.

@sphuber
Copy link
Contributor

sphuber commented Apr 9, 2020

The problem here is that you just updated your branch but did not pip install && reentry scan it. This is standard procedure and is in the documentation for when you update your AiiDA version. The reason that I did not add this explanation in this warning message, is because this is not the only reason. Here it concerns entry points that ship with aiida-core so normally should not be a problem. However, this message is really intended for people who import an archive containing groups from some plugin package that they don't have installed. aiida-core cannot know from which package they come from so cannot say how to install them.

@ltalirz
Copy link
Member Author

ltalirz commented Apr 9, 2020

Ok, that's already much better...

However, I would be willing to bet money that others will forget to reentry scan as well.

However, this message is really intended for people who import an archive containing groups from some plugin package that they don't have installed. aiida-core cannot know from which package they come from so cannot say how to install them.

Right. We could still add something like "if you've recently upgraded aiida-core, you may want to try running reentry scan".

Also, maybe I didn't pay enough attention, but was there a message concerning this when doing the migration?
That might be another place to warn about this.

@chrisjsewell
Copy link
Member

reentry scan no longer needed, so I guess we can close this 😄

Perhaps though we should add the module path namespace['__module__'] to the warning message?

@sphuber
Copy link
Contributor

sphuber commented Aug 12, 2021

reentry scan no longer needed, so I guess we can close this smile

Agreed

Perhaps though we should add the module path namespace['__module__'] to the warning message?

Don't think it is necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants