Pre-commit: reintroduce pylint rules #4501
Conversation
|
@sphuber I started reducing the number of local variables in a few places until I realized that we had increased the acceptable limit to 20 ;-) |
ltalirz
force-pushed
the
pylint-rules
branch
2 times, most recently
from
e593f71 to
d52fd14
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4501 +/- ##
===========================================
- Coverage 79.37% 79.36% -0.00%
===========================================
Files 475 475
Lines 34930 34907 -23
===========================================
- Hits 27721 27702 -19
+ Misses 7209 7205 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -10,6 +10,9 @@ | |||
| """ | |||
| This allows to manage showfunctionality to all data types. | |||
| """ | |||
| import sys | |||
There was a problem hiding this comment.
Could those have been put in the functions to improve startup performance?
There was a problem hiding this comment.
done!
you're right, here it makes sense to move imports inside functions (although those system libraries are likely imported somewhere anyhow)
In 65ad067 the following pylint rules were accidentally disabled: * missing-class-docstring * missing-function-docstring * too-many-ancestors * too-many-locals This commit reintroduces all but the "too-many-ancestors" rule, which was deemed not to be helpful, since it has never prompted refactoring in the past.
In 65ad067 the following pylint rules
were accidentally disabled:
This commit reintroduces all but the "too-many-ancestors" rule, which
was deemed not to be helpful, since it has never prompted refactoring in
the past.