CI: move pylint configuration to pyproject.toml (#4411)

This is supported by `pylint` as of v2.5.
aiidateam · Sep 28, 2020 · 65ad067 · 65ad067
1 parent e2b5385
commit 65ad067
Show file tree

Hide file tree

Showing 59 changed files with 102 additions and 533 deletions.
diff --git a/.pylintrc b/.pylintrc
diff --git a/aiida/backends/djsite/db/migrations/0015_invalidating_node_hash.py b/aiida/backends/djsite/db/migrations/0015_invalidating_node_hash.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Invalidating node hash - User should rehash nodes for caching."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0018_django_1_11.py b/aiida/backends/djsite/db/migrations/0018_django_1_11.py
@@ -8,7 +8,7 @@
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
 # Generated by Django 1.11.16 on 2018-11-12 16:46
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration for upgrade to django 1.11"""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0019_migrate_builtin_calculations.py b/aiida/backends/djsite/db/migrations/0019_migrate_builtin_calculations.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration to reflect the name change of the built in calculation entry points in the database."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0020_provenance_redesign.py b/aiida/backends/djsite/db/migrations/0020_provenance_redesign.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods,unused-argument
+# pylint: disable=invalid-name,unused-argument
 """Migration after the provenance redesign"""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0021_dbgroup_name_to_label_type_to_type_string.py b/aiida/backends/djsite/db/migrations/0021_dbgroup_name_to_label_type_to_type_string.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration that renames name and type columns to label and type_string"""
 
 # pylint: disable=no-name-in-module,import-error

diff --git a/aiida/backends/djsite/db/migrations/0022_dbgroup_type_string_change_content.py b/aiida/backends/djsite/db/migrations/0022_dbgroup_type_string_change_content.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration after the update of group_types"""
 
 # pylint: disable=no-name-in-module,import-error

diff --git a/aiida/backends/djsite/db/migrations/0023_calc_job_option_attribute_keys.py b/aiida/backends/djsite/db/migrations/0023_calc_job_option_attribute_keys.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration of ProcessNode attributes for metadata options whose key changed."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0024_dblog_update.py b/aiida/backends/djsite/db/migrations/0024_dblog_update.py
@@ -8,7 +8,7 @@
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
 # Generated by Django 1.11.16 on 2018-12-21 10:56
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration for the update of the DbLog table. Addition of uuids"""
 
 import sys

diff --git a/aiida/backends/djsite/db/migrations/0025_move_data_within_node_module.py b/aiida/backends/djsite/db/migrations/0025_move_data_within_node_module.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Data migration for `Data` nodes after it was moved in the `aiida.orm.node` module changing the type string."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0026_trajectory_symbols_to_attribute.py b/aiida/backends/djsite/db/migrations/0026_trajectory_symbols_to_attribute.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Data migration for `TrajectoryData` nodes where symbol lists are moved from repository array to attribute.
 
 This process has to be done in two separate consecutive migrations to prevent data loss in between.

diff --git a/aiida/backends/djsite/db/migrations/0027_delete_trajectory_symbols_array.py b/aiida/backends/djsite/db/migrations/0027_delete_trajectory_symbols_array.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Data migration for `TrajectoryData` nodes where symbol lists are moved from repository array to attribute.
 
 This process has to be done in two separate consecutive migrations to prevent data loss in between.

diff --git a/aiida/backends/djsite/db/migrations/0028_remove_node_prefix.py b/aiida/backends/djsite/db/migrations/0028_remove_node_prefix.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Final data migration for `Nodes` after `aiida.orm.nodes` reorganization was finalized to remove the `node.` prefix"""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0029_rename_parameter_data_to_dict.py b/aiida/backends/djsite/db/migrations/0029_rename_parameter_data_to_dict.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Data migration for after `ParameterData` was renamed to `Dict`."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0030_dbnode_type_to_dbnode_node_type.py b/aiida/backends/djsite/db/migrations/0030_dbnode_type_to_dbnode_node_type.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Renaming `DbNode.type` to `DbNode.node_type`"""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0031_remove_dbcomputer_enabled.py b/aiida/backends/djsite/db/migrations/0031_remove_dbcomputer_enabled.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Remove `DbComputer.enabled`"""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0032_remove_legacy_workflows.py b/aiida/backends/djsite/db/migrations/0032_remove_legacy_workflows.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Remove legacy workflow."""
 
 import sys

diff --git a/aiida/backends/djsite/db/migrations/0033_replace_text_field_with_json_field.py b/aiida/backends/djsite/db/migrations/0033_replace_text_field_with_json_field.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Replace use of text fields to store JSON data with builtin JSONField."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0034_drop_node_columns_nodeversion_public.py b/aiida/backends/djsite/db/migrations/0034_drop_node_columns_nodeversion_public.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Drop the columns `nodeversion` and `public` from the `DbNode` model."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0035_simplify_user_model.py b/aiida/backends/djsite/db/migrations/0035_simplify_user_model.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Simplify the `DbUser` model."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0036_drop_computer_transport_params.py b/aiida/backends/djsite/db/migrations/0036_drop_computer_transport_params.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Drop the `transport_params` from the `Computer` database model."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0037_attributes_extras_settings_json.py b/aiida/backends/djsite/db/migrations/0037_attributes_extras_settings_json.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,import-error,no-name-in-module,too-few-public-methods,no-member
+# pylint: disable=invalid-name,import-error,no-name-in-module,no-member
 """Adding JSONB field for Node.attributes and Node.Extras"""
 
 import math

diff --git a/aiida/backends/djsite/db/migrations/0038_data_migration_legacy_job_calculations.py b/aiida/backends/djsite/db/migrations/0038_data_migration_legacy_job_calculations.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Data migration for legacy `JobCalculations`.
 
 These old nodes have already been migrated to the correct `CalcJobNode` type in a previous migration, but they can

diff --git a/aiida/backends/djsite/db/migrations/0039_reset_hash.py b/aiida/backends/djsite/db/migrations/0039_reset_hash.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """
 Invalidating node hash - User should rehash nodes for caching
 """

diff --git a/aiida/backends/djsite/db/migrations/0040_data_migration_legacy_process_attributes.py b/aiida/backends/djsite/db/migrations/0040_data_migration_legacy_process_attributes.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Data migration for some legacy process attributes.
 
 Attribute keys that are renamed:

diff --git a/aiida/backends/djsite/db/migrations/0041_seal_unsealed_processes.py b/aiida/backends/djsite/db/migrations/0041_seal_unsealed_processes.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Seal any process nodes that have not yet been sealed but should.
 
 This should have been accomplished by the last step in the previous migration, but because the WHERE clause was

diff --git a/aiida/backends/djsite/db/migrations/0042_prepare_schema_reset.py b/aiida/backends/djsite/db/migrations/0042_prepare_schema_reset.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Prepare the schema reset."""
 
 # Remove when https://github.com/PyCQA/pylint/issues/1931 is fixed

diff --git a/aiida/backends/djsite/db/migrations/0043_default_link_label.py b/aiida/backends/djsite/db/migrations/0043_default_link_label.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Update all link labels with the value `_return` which is the legacy default single link label.
 
 The old process functions used to use `_return` as the default link label, however, since labels that start or end with

diff --git a/aiida/backends/djsite/db/migrations/0044_dbgroup_type_string.py b/aiida/backends/djsite/db/migrations/0044_dbgroup_type_string.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods
+# pylint: disable=invalid-name
 """Migration after the `Group` class became pluginnable and so the group `type_string` changed."""
 
 # pylint: disable=no-name-in-module,import-error

diff --git a/aiida/backends/djsite/db/models.py b/aiida/backends/djsite/db/models.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=import-error,no-name-in-module
+# pylint: disable=import-error,no-name-in-module,no-member
 """Module that defines db models."""
 import contextlib
 
@@ -63,7 +63,7 @@ def get_queryset(self):
         return AiidaQuerySet(self.model, using=self._db)
 
 
-class DbUser(m.Model):  # pylint: disable=too-few-public-methods
+class DbUser(m.Model):
     """Class that represents a user as the owner of a specific Node."""
 
     is_anonymous = False
@@ -257,7 +257,7 @@ class DbGroup(m.Model):
     # JSON Extras
     extras = JSONField(default=dict, null=False)
 
-    class Meta:  # pylint: disable=too-few-public-methods
+    class Meta:
         unique_together = (('label', 'type_string'),)
 
     def __str__(self):
@@ -325,7 +325,7 @@ class DbAuthInfo(m.Model):
     # Whether this computer is enabled (user-level enabling feature)
     enabled = m.BooleanField(default=True)
 
-    class Meta:  # pylint: disable=too-few-public-methods
+    class Meta:
         unique_together = (('aiidauser', 'dbcomputer'),)
 
     def __str__(self):

diff --git a/aiida/backends/sqlalchemy/migrations/versions/5d4d844852b6_invalidating_node_hash.py b/aiida/backends/sqlalchemy/migrations/versions/5d4d844852b6_invalidating_node_hash.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods,no-member
+# pylint: disable=invalid-name
 """Invalidating node hash - User should rehash nodes for caching
 
 Revision ID: 5d4d844852b6
@@ -33,7 +33,7 @@
 
 def upgrade():
     """drop the hashes when upgrading"""
-    conn = op.get_bind()
+    conn = op.get_bind()  # pylint: disable=no-member
 
     # Invalidate all the hashes
     statement = text("""UPDATE db_dbnode SET extras = extras #- '{""" + _HASH_EXTRA_KEY + """}'::text[];""")
@@ -42,7 +42,7 @@ def upgrade():
 
 def downgrade():
     """drop the hashes also when downgrading"""
-    conn = op.get_bind()
+    conn = op.get_bind()  # pylint: disable=no-member
 
     # Invalidate all the hashes
     statement = text("""UPDATE db_dbnode SET extras = extras #- '{""" + _HASH_EXTRA_KEY + """}'::text[];""")

diff --git a/aiida/backends/sqlalchemy/migrations/versions/e797afa09270_reset_hash.py b/aiida/backends/sqlalchemy/migrations/versions/e797afa09270_reset_hash.py
@@ -7,7 +7,7 @@
 # For further information on the license, see the LICENSE.txt file        #
 # For further information please visit http://www.aiida.net               #
 ###########################################################################
-# pylint: disable=invalid-name,too-few-public-methods,no-member
+# pylint: disable=invalid-name
 """Invalidating node hash - User should rehash nodes for caching
 
 Revision ID: e797afa09270
@@ -47,9 +47,9 @@ def drop_hashes(conn):  # pylint: disable=unused-argument
 
 def upgrade():
     """drop the hashes when upgrading"""
-    drop_hashes(op.get_bind())
+    drop_hashes(op.get_bind())  # pylint: disable=no-member
 
 
 def downgrade():
     """drop the hashes also when downgrading"""
-    drop_hashes(op.get_bind())
+    drop_hashes(op.get_bind())  # pylint: disable=no-member
diff --git a/aiida/cmdline/commands/cmd_import.py b/aiida/cmdline/commands/cmd_import.py
@@ -25,7 +25,6 @@
 COMMENT_MODE = ['newest', 'overwrite']
 
 
-# pylint: disable=too-few-public-methods
 class ExtrasImportCode(Enum):
     """Exit codes for the verdi command line."""
     keep_existing = 'kcl'

diff --git a/aiida/cmdline/params/arguments/overridable.py b/aiida/cmdline/params/arguments/overridable.py
@@ -38,8 +38,6 @@ def print_code_pks(codes):
     the function argument name is determined, can be overriden
     """
 
-    # pylint: disable=too-few-public-methods
-
     def __init__(self, *args, **kwargs):
         """
         Store the default args and kwargs

diff --git a/aiida/cmdline/utils/echo.py b/aiida/cmdline/utils/echo.py
@@ -22,7 +22,6 @@
 )
 
 
-# pylint: disable=too-few-public-methods
 class ExitCode(IntEnum):
     """Exit codes for the verdi command line."""
     CRITICAL = 1

diff --git a/aiida/cmdline/utils/repository.py b/aiida/cmdline/utils/repository.py
@@ -22,5 +22,4 @@ def list_repository_contents(node, path, color):
 
     for entry in node.list_objects(path):
         bold = bool(entry.file_type == FileType.DIRECTORY)
-        fg = 'blue' if color and entry.file_type == FileType.DIRECTORY else None
-        click.secho(entry.name, bold=bold, fg=fg)
+        click.secho(entry.name, bold=bold, fg='blue' if color and entry.file_type == FileType.DIRECTORY else None)
diff --git a/aiida/common/lang.py b/aiida/common/lang.py
@@ -76,7 +76,7 @@ def wrapped_fn(self, *args, **kwargs):  # pylint: disable=missing-docstring
 override = override_decorator(check=False)  # pylint: disable=invalid-name
 
 
-class classproperty:  # pylint: disable=too-few-public-methods,invalid-name
+class classproperty:  # pylint: disable=invalid-name
     """
     A class that, when used as a decorator, works as if the
     two decorators @property and @classmethod where applied together

diff --git a/aiida/engine/daemon/client.py b/aiida/engine/daemon/client.py
@@ -24,7 +24,7 @@
 VIRTUALENV = os.environ.get('VIRTUAL_ENV', None)
 
 
-class ControllerProtocol(enum.Enum):  # pylint: disable=too-few-public-methods
+class ControllerProtocol(enum.Enum):
     """
     The protocol to use to for the controller of the Circus daemon
     """