-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Revise "Get started" flow #4496
Docs: Revise "Get started" flow #4496
Conversation
3185544
to
7d11104
Compare
Ah look at those awesome tabs! I wonder who wrote that code 😝 https://1535-77234579-gh.circle-artifacts.com/0/html/intro/get_started.html |
@greschd and @zhubonan Could you help me fix up the Windows Subsystem installation flow? I don't think it is 100% correct/complete at the moment. Unfortunately I do not have access to a windows machine. |
The tabs are really great! 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial comments
docs/source/intro/get_started.rst
Outdated
|
||
*Use a pre-made image of all the required software.* | ||
.. link-button:: intro:get_started:virtual-machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps link straight to https://quantum-mobile.readthedocs.io here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea. Do you know if it is possible to open the link in a new tab/window?
docs/source/intro/get_started.rst
Outdated
|
||
.. tabbed:: Ubuntu | ||
|
||
*AiiDA is tested on Ubuntu versions 14.04, 16.04, and 18.04.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to update this at some point to 16.04, 18.04, 20.04.
I've anyhow started upgrading Quantum Mobile roles to be tested against 18.04 and 20.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will just update that now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was meant to be request changes
I use the Ubuntu rabbitmq now (I think this didn't work in WSL1) - not sure if we should change the instructions accordingly. @zhubonan what's your experience here? Two other points:
|
Paging @ltalirz and @sphuber who probably also are interested in checking how this turned out. Should @csadorf maybe give a general overview/demo of how it looks like today in the AiiDA meeting so that @giovannipizzi can take a look at it without having to go through the PR now? |
@ramirezfranciscof I've marked this PR as a draft, because the WSL instructions still need to be fixed. |
@greschd Thank you very much, that is already very helpful. Would you potentially be able/willing to directly push an edit to this branch? |
@csadorf @greschd I think on WSL1 the Ubuntu native RabbitMQ does not work. We should definitely differentiate between WSL1 and WSL2. The current instructions seem OK to me for WSL1. I have not used WSL2 @greschd. My main concern is that the files system access to the Windows side appears to be much slower in WSL2 than WSL1 and I store my data in the Windows file system. Also, WSL2 seems to block quite a bit RAM? I have WSL2 installed in a different machine but I don't have AiiDA installed there. How did you find the WSL2 experience so far? Maybe there should be some remarks about choosing between the two, |
Yeah I've had mostly good experiences with WSL2 - but the files I work on with WSL aren't on the Windows drive. Not sure about the RAM issue, I would probably need to look more closely. But this is just my development environment, production is on a separate machine. The only difference between WSL1/2 in terms of installing would be where RabbitMQ is installed. The "startup via TaskScheduler" would again be the same. |
@greschd I see. For development it should be pretty good, I run both production and development in WSL so disk space is a concern. Also, the growing VHD files for WSL2 will be very big if used for production I would imaging, and that is not easily reclaimable. |
@zhubonan It seems to me like we should show instructions for WSL 2, but show a disclaimer that there might be issues with file system performance in which case we recommend that users should use version 1 (and mention the difference w.r.t. RabbitMQ). Beyond that I think we should be careful about taking on too much responsibility about shortcomings of various systems that are outside of our control. @greschd Could you help me with the instructions for the scheduler? Do users still need to create the mentioned script and then place it in the TaskScheduler or so? Both, can you verify that the mentioned issue concerning time zones is still a problem? Reading through the issue comments it might be resolved? |
Yes, the TaskScheduler would just execute that script at startup; I can write some instructions, but not sure how fool-proof that will be. I never had the timezone issue AFAICR. |
That would be very much appreciated. I will try to find some additional testers as well.
Ok, I'm inclined to remove that. |
.. _intro:install:docker: | ||
|
||
**************************** | ||
Run AiiDA via a Docker image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes a number of helpful commands from the original "Using the Docker image" section, for example the one you need to actual enter the container:
docker exec -it --user aiida aiida-container /bin/bash
plus the note about using /tmp/my_data
, which is the only place writable by the aiida user, and the command to mount it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was actually a bit confused about that section. I'll restore the things that got removed, but I also want to avoid making this too much of a general docker tutorial. But I'm slightly less concerned about the length now that the instructions are on their own separate page.
925e1a2
to
ad029a1
Compare
@csadorf I added the text but didn't check the formatting - my local install is slightly broken ATM (at least, it can't build the docs). Could you format it to your liking? |
35e0131
to
ccae4fe
Compare
Great, very much appreciated. No worries about the formatting, I will take care of that. |
8466141
to
1774ae8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WSL instructions look good to me, except I'm not 100% sure about the instructions I wrote anymore (see comment) 😅
Thanks a lot! I am actually not 100% clear on the difference between "hint" and "tip". Maybe that's something we should clarify in the wiki? I'd be fine with just using "tip" everywhere instead of "hint". |
- Overhaul of page structure and installation flow. - Incorporate content from detailed installation page.
And remove all content covered by the get started page.
That makes it more likely for users to choose that method which is overall still better supported than Conda; the latter has no provision to install extras.
- Distinguishes between WSL 1 / 2 by how RabbitMQ is installed only - Adds instructions for setting up a task in Task Scheduler for starting the services. - Removes the warning about the timezone problem, as it seems to be fixed.
To retain more from the previous advanced installation instructions.
1774ae8
to
a9c57c6
Compare
@greschd @chrisjsewell Sorry, your reviews were dismissed when I replaced all 'hints' with 'tips'. This should have been the last commit on this. |
@ramirezfranciscof Do you still want to review this or should I merge it? |
I was going to give it a pass today but got other inconvenients I had to (and still have to) solve. Since I think you already received enough reviews from other people I think it is ok if you want to go ahead and merge it. |
Ok, I'll merge it then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass given, this looks great!
My only tiny silly comment would be if we could add somewhere in the System-wide
tile that this is the recommended installation for a work setup. It might be obvious from the text in the tiles that if you don't have admin then you should do the conda-env, but perhaps if you do have it, you may be unsure of wether you should be using it or not (kind of like you shouldn't use "sudo pip install" even if you are sudoer).
Anyway, up to you.
Like I said in the description of this PR, I don't think it is that easy to recommend one method over the other. It depends on your circumstances, your needs, and your familiarity with certain technologies. That the system-wide method requires admin rights, and the pure-conda method does not should be abundantly clear now. Therefore, in the proposed revision we do not recommend any specific method over another, but instead show a slight preference for specific methods via the ordering of the tiles, and furthermore, via this sentence:
|
Ah, sorry, I totally missed that sentence. Disregard the comment, all GTG. |
This is a comprehensive revision of the "Get started" and "Advanced installation" page to address the issues identified in #4254 .
In summary, the "Get started" page has been completely revised to provide a more linear flow for all supported setup flows and the "Detailed installation" has been largely pruned and renamed to "Advanced configuration" with most content directly incorporated into the linear setup flows.
These are the changes in detail: