Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing the last stretch of the doc-days #4524

Closed
ramirezfranciscof opened this issue Oct 28, 2020 · 8 comments
Closed

Finishing the last stretch of the doc-days #4524

ramirezfranciscof opened this issue Oct 28, 2020 · 8 comments
Assignees

Comments

@ramirezfranciscof
Copy link
Member

During the dedicated doc days we managed to get done almost all of the most pressing outstanding issues regarding the documentation revamp, great job everyone!

However, even though there have been just a couple of issues that remain to be done, things have naturally become slower now. To help with that so that we can fully close this workbatch, I'm opening this issue to gather here all tasks that remain to be done and ping the people in charge to check the status of each.

  1. Flow of introduction (PR Docs: Revise "Get started" flow #4496): Work in progress by @csadorf, will be reviewed by me. Do you have an estimate on when this could be ready?
  2. Topics - Scheduler Plugin (PR Docs: Instructions on creating scheduler plugin #4476): Work done by @yakutovicha , pending review by @sphuber, do you think you can take a look at this today?
  3. Topics - Datatypes (PR Docs: Move data types to Topics section #4469): Work done by @mbercx , pending review/feedback by @giovannipizzi . Not sure if maybe you had any discussion in person/zoom, but in the PR it seems @mbercx is waiting for @giovannipizzi to reply to some questions.
  4. How to Extend Workflows (PR pending): This should also incorporate whatever suggestion remains relevant from this older issue. This is in charge of @mbercx and I will be reviewing it; are you currently working in this? do you have an estimate of when you could make a PR?
  5. Topics - Caching (PR pending): This should also incorporate the documentation related suggestions from this other issue. This is in charge of @ltalirz , were you able to take a look at this and decide what can be incorporated now and what should be left for the future?

Please, if you were tagged above, check the item and reply here to any question addressed to you so that we can assess the status of this. Thanks!

@ltalirz
Copy link
Member

ltalirz commented Oct 28, 2020

Topics - Caching (PR pending): This should also incorporate the documentation related suggestions from this other issue. This is in charge of @ltalirz , were you able to take a look at this and decide what can be incorporated now and what should be left for the future?

This is not really urgent and I don't have time for it right now. We can take care of it during the next coding days; feel free to unassign me.

@sphuber
Copy link
Contributor

sphuber commented Oct 28, 2020

I will look at #4476 now

@ramirezfranciscof
Copy link
Member Author

I will look at #4476 now

@sphuber thanks!

This is not really urgent and I don't have time for it right now. We can take care of it during the next coding days; feel free to unassign me.

Mmm, ok; although the topic may not be super urgent, this involves re-incorporating some of the old content into the new docs which was one of the "objectives" of this days, so at least that part we should finish. If you are busy then I can take care of doing that re-incorporation and then we can leave for later your compiled improvements.

@csadorf
Copy link
Contributor

csadorf commented Oct 28, 2020

Flow of introduction (PR #4496): Work in progress by @csadorf, will be reviewed by me. Do you have an estimate on when this could be ready?

I think that should be ready by early next week.

@mbercx
Copy link
Member

mbercx commented Oct 28, 2020

  1. Topics - Datatypes (PR Docs: Move data types to Topics section #4469): Work done by @mbercx , pending review/feedback by @giovannipizzi . Not sure if maybe you had any discussion in person/zoom, but in the PR it seems @mbercx is waiting for @giovannipizzi to reply to some questions.

The PR is waiting for @giovannipizzi's review indeed, but I think Gio mentioned that it's ok to merge for now. I'll definitely be opening another issue to add the final data types, so I can go over the whole section again at that time.

  1. How to Extend Workflows (PR pending): This should also incorporate whatever suggestion remains relevant from this older issue. This is in charge of @mbercx and I will be reviewing it; are you currently working in this? do you have an
    estimate of when you could make a PR?

I've already done some work on this, but it's not quite finished. I'll prioritise this so I can have a first draft today/tomorrow.

@ramirezfranciscof
Copy link
Member Author

I've already done some work on this, but it's not quite finished. I'll prioritise this so I can have a first draft today/tomorrow.

I see, no hurry. Probably I won't have time to review this tomorrow so I will anyways do it on friday.

The PR is waiting for @giovannipizzi's review indeed, but I think Gio mentioned that it's ok to merge for now. I'll definitely be opening another issue to add the final data types, so I can go over the whole section again at that time.

Ok, then could you rebase it and change the draft status so then @giovannipizzi can leave an aproving review? I can merge it afterwards. Also, best if you can open the issue now so that we don't forget. Thanks!

@ramirezfranciscof ramirezfranciscof added this to the v1.5.0 milestone Nov 2, 2020
@yakutovicha
Copy link
Contributor

#4476 is done, btw.

@ramirezfranciscof ramirezfranciscof removed this from the v1.5.0 milestone Nov 11, 2020
@chrisjsewell
Copy link
Member

Closing this, since all the referenced PRs have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants