Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Instructions on creating scheduler plugin #4476

Merged
merged 6 commits into from
Nov 3, 2020
Merged

Docs: Instructions on creating scheduler plugin #4476

merged 6 commits into from
Nov 3, 2020

Conversation

yakutovicha
Copy link
Contributor

@yakutovicha yakutovicha commented Oct 19, 2020 •
edited
Loading

fixes #3989

@yakutovicha yakutovicha marked this pull request as draft October 19, 2020 22:37
@giovannipizzi giovannipizzi changed the title Instructions on creating scheduler plugin Docs: Instructions on creating scheduler plugin Oct 20, 2020
@yakutovicha yakutovicha requested a review from sphuber October 21, 2020 08:47
@yakutovicha yakutovicha marked this pull request as ready for review October 21, 2020 08:47
@ramirezfranciscof ramirezfranciscof mentioned this pull request Oct 28, 2020
Closed
sphuber
sphuber requested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yakutovicha , couple of suggestions

docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/schedulers.rst Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/scheduler_template.py Outdated Show resolved Hide resolved
docs/source/topics/schedulers.rst Outdated Show resolved Hide resolved
@yakutovicha yakutovicha requested a review from sphuber October 28, 2020 14:26
@yakutovicha
Copy link
Contributor Author

@sphuber anything else I should do?

@sphuber
Copy link
Contributor

sphuber commented Nov 3, 2020

@sphuber anything else I should do?

Yes, there is still a comment that is not addressed.

@yakutovicha
Copy link
Contributor Author

@sphuber anything else I should do?

Yes, there is still a comment that is not addressed.

Ah, sorry, I missed it. Will address that one now.

@yakutovicha
Copy link
Contributor Author

@sphuber anything else I should do?

Yes, there is still a comment that is not addressed.

It is done now.

sphuber
sphuber approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yakutovicha

@sphuber sphuber merged commit eea2773 into aiidateam:develop Nov 3, 2020
@yakutovicha yakutovicha deleted the docs/create-scheduler-plugin-3989 branch November 3, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphuber sphuber sphuber approved these changes

Assignees

@sphuber sphuber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Topics (scheduler plugins)
2 participants
@yakutovicha @sphuber