Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exit codes #1654

Merged
merged 1 commit into from
Jun 18, 2018
Merged

fix exit codes #1654

merged 1 commit into from
Jun 18, 2018

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Jun 18, 2018

Fixes #1654

@giovannipizzi Since we are using this enum elsewhere as well, we stuck with it (meaning we have to use .value).
I could move to an IntEnum if you like.

@ltalirz ltalirz requested a review from giovannipizzi June 18, 2018 15:42
@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #1654 into verdi will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##            verdi    #1654   +/-   ##
=======================================
  Coverage   59.14%   59.14%           
=======================================
  Files         294      294           
  Lines       34526    34526           
=======================================
  Hits        20422    20422           
  Misses      14104    14104
Impacted Files Coverage Δ
aiida/cmdline/utils/echo.py 80.64% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c1718...3892ebe. Read the comment docs.

@sphuber sphuber merged commit 48d723e into aiidateam:verdi Jun 18, 2018
@ltalirz ltalirz deleted the issue_1653_fix_exit_code branch June 26, 2018 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants