You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The changes introduced in #1648 are partially incorrect.
For instance, calling sys.exit(ExitCode.UNKNOWN)
prints ExitCode.UNKNOWN on the screen before exiting (this is because ExitCode.UNKNOWN is a special type and not simply its value. One e.g. should do sys.exit(ExitCode.UNKNOWN.value). It would be ideal if we find a way to have an enum passing directly its values rather than going in the code and putting a .value everywhere, but I don't know if it's possible
always exits with error code 1 as sys.exit() does not know how to get the value from that object
The same problem in e.g. echo_critical (that I would still like to be called echo_critical_exit ;-) ), even if point 2 is less apparent because ExitCode.CRITICAL is 1
The text was updated successfully, but these errors were encountered:
The changes introduced in #1648 are partially incorrect.
For instance, calling
sys.exit(ExitCode.UNKNOWN)
ExitCode.UNKNOWN
on the screen before exiting (this is becauseExitCode.UNKNOWN
is a special type and not simply its value. One e.g. should dosys.exit(ExitCode.UNKNOWN.value)
. It would be ideal if we find a way to have an enum passing directly its values rather than going in the code and putting a.value
everywhere, but I don't know if it's possiblesys.exit()
does not know how to get the value from that objectThe same problem in e.g.
echo_critical
(that I would still like to be calledecho_critical_exit
;-) ), even if point 2 is less apparent becauseExitCode.CRITICAL
is 1The text was updated successfully, but these errors were encountered: