Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

63 removal of deprecated features #69

Merged

Conversation

JPchico
Copy link
Collaborator

@JPchico JPchico commented Apr 26, 2023

Hello!

I have removed the deprecated features as we discussed in #63.

I added some examples and changes to the documentation to explain how things have changed from the previous releases.

My plan is to make an overhaul to the documentation once the last couple of pieces are there.

Jonathan Chico and others added 4 commits April 14, 2023 12:40
… to their parent directories.

Removing unnecessary tests.

Removing tools for reaxff as they should not be necessary anymore.
…s in the new format.

Adding examples for the restart file.
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #69 (f2994eb) into develop (186afeb) will decrease coverage by 7.89%.
The diff coverage is 82.08%.

@@             Coverage Diff             @@
##           develop      #69      +/-   ##
===========================================
- Coverage    91.21%   83.33%   -7.89%     
===========================================
  Files           33       16      -17     
  Lines         2652     1440    -1212     
===========================================
- Hits          2419     1200    -1219     
- Misses         233      240       +7     
Flag Coverage Δ
pytests 83.33% <82.08%> (-7.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiida_lammps/parsers/base.py 86.66% <ø> (ø)
aiida_lammps/data/potential.py 81.46% <81.76%> (-12.29%) ⬇️
aiida_lammps/calculations/base.py 97.24% <100.00%> (ø)
aiida_lammps/common/input_generator.py 87.31% <100.00%> (ø)
aiida_lammps/fixtures/data.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Member

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JPchico

@JPchico JPchico merged commit 0086836 into aiidaplugins:develop Apr 27, 2023
@JPchico
Copy link
Collaborator Author

JPchico commented Apr 27, 2023

No problem @sphuber ! Thanks for the help!

@JPchico JPchico deleted the 63-removal-of-deprecated-features branch April 27, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants