Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated features #63

Closed
JPchico opened this issue Mar 23, 2023 · 3 comments
Closed

Removal of deprecated features #63

JPchico opened this issue Mar 23, 2023 · 3 comments

Comments

@JPchico
Copy link
Collaborator

JPchico commented Mar 23, 2023

Looking at the changes being done to aiida-lammps right now we have two parsers, several potential types and calculations. All of them are basically redundant by the new BaseLammpsCalculation and LammpsPotentialtypes.

I think that we probably should remove them to make sure that the code is more streamlined and easy to maintain.

The idea was to keep them for backwards compatibility, but in principle for any new calculation one can use the new functions.

Perhaps one can give a way of importing old calculations using a immigrant function that uses the clever input_script input from @sphuber

I'm all for cleaning this up and keeping only one parser, one calculation and one potential structure. The rest of the specific cases can be treated by custom workchains.

What do you think @chrisjsewell ?

@chrisjsewell
Copy link
Member

All of them are basically redundant by the new BaseLammpsCalculation and LammpsPotentialtypes.

yeh I'd be happy for you to deprecate them 👍

perhaps you could add some documentation, if its not there already, on how you can now run the old calculations using the new infrastructure

@JPchico
Copy link
Collaborator Author

JPchico commented Mar 27, 2023

That seems fine by me.
I have examples on how to run some of them, but I'll make sure that there are examples for all of them and then I'll remove them

@JPchico
Copy link
Collaborator Author

JPchico commented Apr 27, 2023

Closed via #69

@JPchico JPchico closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants