Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using new code create API #394

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Using new code create API #394

merged 6 commits into from
Nov 29, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 21, 2022 •
edited by danielhollas
Loading

Closes #393

@unkcpz unkcpz mentioned this pull request Nov 21, 2022
Closed
@unkcpz
Copy link
Member Author

unkcpz commented Nov 21, 2022

This will still have one Code deprecation warning but rooted from aiida-core as mentioned by @sphuber today, I think we can not do anything from the AiiDAlab side.

@yakutovicha
Copy link
Member

I am so annoyed by those random readthedocs failures.

@danielhollas
Copy link
Contributor

danielhollas commented Nov 22, 2022 •
edited
Loading

Looking at the error, it looks like the distutils issue that @unkcpz mentioned on Slack, and that is explained in aiida-core as well

aiidateam/aiida-core#5782

EDIT: I guess this will get solved once we move to pyproject.toml and flit

#390 (comment)

@unkcpz
Copy link
Member Author

unkcpz commented Nov 22, 2022

I am so annoyed by those random readthedocs failures.

As @danielhollas said, yes, I think this will be fixed by pining the setuptools version, but we are going to move to pyproject.toml and we 'll do it after that. So maybe we can ignore the failed DOC build failure at the moment?

@unkcpz unkcpz requested a review from danielhollas November 28, 2022 18:35
danielhollas
danielhollas approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't actually test the changes as it is kind of hard for me to do so without access to Swiss clusters but I trust that you did :-)

@unkcpz unkcpz enabled auto-merge (squash) November 29, 2022 09:25
@unkcpz unkcpz merged commit 0c6bfd7 into master Nov 29, 2022
@unkcpz unkcpz deleted the code-setup-new-api branch November 29, 2022 09:48
This was referenced Dec 1, 2022
Merged
Closed
unkcpz added a commit to unkcpz/aiidalab-widgets-base that referenced this pull request Nov 16, 2023
@unkcpz
bump AWB to released 2.0 (aiidalab#394)
e0217c5 
`aiidalab-widgets-base` 2.0 is released, the version is bump here. Jinja2 and importlib are from aiida-quantumespresso, therefore the version is loosely pinned. The pybtex has to be added to work around the installation issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhollas danielhollas danielhollas approved these changes

Assignees

@unkcpz unkcpz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration ComputationalResourceWidget to AiiDA 2.1
3 participants
@unkcpz @yakutovicha @danielhollas