Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two more deprecated APIs with AIIDA_WARN_v3=1 for QeApp #390

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Nov 20, 2022

No description provided.

danielhollas
danielhollas previously approved these changes Nov 20, 2022
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz. LGTM

@unkcpz
Copy link
Member Author

unkcpz commented Nov 21, 2022

The doc test failed because of the setuptools bug: numpy/numpy#22623
We can pinned the setuptools after migrate to using only pyproject.toml for package setup.

@yakutovicha
Copy link
Member

The doc test failed because of the setuptools bug: numpy/numpy#22623 We can pinned the setuptools after migrate to using only pyproject.toml for package setup.

yes, let's merge this now, and fix the tests using pyproject.toml

@yakutovicha yakutovicha merged commit 4bc6f14 into master Nov 21, 2022
@yakutovicha yakutovicha deleted the more-deprecated-apis branch November 21, 2022 11:05
unkcpz pushed a commit to unkcpz/aiidalab-widgets-base that referenced this pull request Nov 16, 2023
Fix aiidalab#390

The electronic structure panel is still hardcoded because it needs the results from both bands and pdos plugins. When we find a good solution to support results from multiple plugin, we can remove both the code in the electronic structure result and the code in the workchain.

For the moment, we remove the code in the workchain, but still hardcoded the electronic structure result panel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants