Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select from Example structures widget back #215

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Mar 14, 2022

Fix #152

Add the StructureExamplesWidget back to structure manager widget
with more examples.

Add the `StructureExamplesWidget` back to structure manager widget
with more examples.
@unkcpz
Copy link
Member Author

unkcpz commented Mar 14, 2022

Happy to add more example structures if you can provide the files.

@unkcpz unkcpz requested review from csadorf and mbercx April 4, 2022 10:57
Copy link
Member

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these structures well-tested, i.e., do we know that they run robustly and yield the correct results?

@unkcpz
Copy link
Member Author

unkcpz commented Apr 5, 2022

Should be all good after the spin-polarization PR merged, which failed the Cobalt calculation. I will give all structures final tests late today.

@unkcpz
Copy link
Member Author

unkcpz commented Apr 6, 2022

New examples are all working fine, should be safe to merged. Test on Au.cif which is not a primitive cell and Co.cif which has spin-polarization turned on and others are old examples the regular insulators.

@unkcpz unkcpz requested a review from csadorf April 6, 2022 12:52
@unkcpz unkcpz merged commit e756b97 into master Apr 6, 2022
@unkcpz unkcpz deleted the fix/152/example-structures branch April 6, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why remove StructureExampleWidget?
2 participants