Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why remove StructureExampleWidget? #152

Closed
unkcpz opened this issue Nov 11, 2021 · 6 comments · Fixed by #215
Closed

Why remove StructureExampleWidget? #152

unkcpz opened this issue Nov 11, 2021 · 6 comments · Fixed by #215
Assignees
Milestone

Comments

@unkcpz
Copy link
Member

unkcpz commented Nov 11, 2021

Is there any reason why you remove StructureExampleWidget from structure_manerger_widget importer?

@csadorf
Copy link
Member

csadorf commented Nov 15, 2021

Yes, Nicola did not like it.

@unkcpz
Copy link
Member Author

unkcpz commented Nov 15, 2021

Well, it is a useful feature during developing.

@csadorf
Copy link
Member

csadorf commented Nov 15, 2021

I agree. What is your opinion on this @giovannipizzi ?

@giovannipizzi
Copy link
Member

I also would be in favour of keeping it - it's always better to have something easy to quickly test without thinking/clicking too much. Indeed, Nicola did not like it, I think. Maybe two things:

  • extend it not to have only Si and SiO2, but also 3-4 more complex structures that don't just look like a demo
  • make it easy to have it optionally, so it's on in "debug" mode (e.g. pre-releases) but not there for releases or something similar (if really Nicola does not want it - otherwise I'd keep it; it's also true that with optimade, it's quite easy to pick an example structure, even if it's still 10 clicks instead of 2...)

@csadorf
Copy link
Member

csadorf commented Nov 15, 2021

extend it not to have only Si and SiO2, but also 3-4 more complex structures that don't just look like a demo

That's probably the right move. 👍

make it easy to have it optionally, so it's on in "debug" mode (e.g. pre-releases) but not there for releases or something similar (if really Nicola does not want it - otherwise I'd keep it; it's also true that with optimade, it's quite easy to pick an example structure, even if it's still 10 clicks instead of 2...)

I would prefer to avoid this if possible.

@unkcpz
Copy link
Member Author

unkcpz commented Nov 15, 2021

extend it not to have only Si and SiO2,

For debug purposes, I would suggest also including Au for metal.

@unkcpz unkcpz added this to the 2022.03.0 milestone Feb 14, 2022
@unkcpz unkcpz self-assigned this Feb 21, 2022
@unkcpz unkcpz modified the milestones: 2022.03.0, 2022.04.0 Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants