Avoid pip v20.3 constraints issue #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbren12
approved these changes
Nov 30, 2020
AnnaKwa
changed the title
AnnaKwa
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v20.3 of pip just got released, so the line
pip install --upgrade pipin the prognostic dockerfile will now upgrade to 20.3 instead of 20.2.4. The newer version has some new dependency resolving features that prevent the pip from installing with the current constraints file:ERROR: Constraints cannot have extras, which makes the prognostic image build fail. This is a bandaid fix for what should probably be resolved by fixingconstraints.txtto not have extras, I didn't want to just start deleting those though in case other stuff broke. I created an issue for this: #814Ex. most recent master prognostic build step that ran the installations of requirements, which passed using the older v20.2.4: https://app.circleci.com/pipelines/github/VulcanClimateModeling/fv3net/6289/workflows/16c85815-5e4d-4fc9-b174-bb6ada028e37/jobs/38693
ex. a prognostic build step after the v20.3 release that fails with the above constraints error: https://app.circleci.com/pipelines/github/VulcanClimateModeling/fv3net/6337/workflows/ee69991d-1d50-46d3-87f2-ffb3b00df460/jobs/39356
Resolves #814