Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extras in constraints.txt lead to breakage with pip v20.3 #814

Closed
AnnaKwa opened this issue Nov 30, 2020 · 1 comment · Fixed by #813
Closed

Extras in constraints.txt lead to breakage with pip v20.3 #814

AnnaKwa opened this issue Nov 30, 2020 · 1 comment · Fixed by #813

Comments

@AnnaKwa
Copy link
Contributor

AnnaKwa commented Nov 30, 2020 •
edited
Loading

Using pip3 install -c constraints.txt ... with the newest pip version v20.3 raises ERROR: Constraints cannot have extras. The short term fix is to pin the pip version to the previous one that worked, the better thing to do would be to figure out what is causing this error in the constraints file and fix it.

pypa/pip#6628
https://stackoverflow.com/questions/52474931/what-is-extra-in-pypi-dependency
@AnnaKwa AnnaKwa mentioned this issue Nov 30, 2020
Merged
@nbren12
Copy link
Contributor

nbren12 commented Nov 30, 2020

For now, maybe we should pin to an earlier version of pip. The constraints.txt is automatically generated via pip-compile, so we shouldn't edit it by hand.

github-actions bot pushed a commit that referenced this issue Dec 1, 2020
Avoid pip v20.3 constraints issue
c7c5bc5 
v20.3 of pip just got released, so the line `pip install --upgrade pip` in the prognostic dockerfile will now upgrade to 20.3 instead of 20.2.4. The newer version has some new dependency resolving features that prevent the pip from installing with the current constraints file: `ERROR: Constraints cannot have extras`, which makes the prognostic image build fail. This is a bandaid fix for what should probably be resolved by fixing `constraints.txt` to not have extras, I didn't want to just start deleting those though in case other stuff broke. I created an issue for this: #814 

Ex. most recent master prognostic build step that ran the installations of requirements, which passed using the older v20.2.4: https://app.circleci.com/pipelines/github/VulcanClimateModeling/fv3net/6289/workflows/16c85815-5e4d-4fc9-b174-bb6ada028e37/jobs/38693

ex. a prognostic build step after the v20.3 release that fails with the above constraints error: https://app.circleci.com/pipelines/github/VulcanClimateModeling/fv3net/6337/workflows/ee69991d-1d50-46d3-87f2-ffb3b00df460/jobs/39356

Resolves #814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid pip v20.3 constraints issue ai2cm/fv3net
2 participants
@nbren12 @AnnaKwa