Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove alpha convert option for ico. Fixes #19 #20

Merged
merged 1 commit into from
Mar 23, 2019
Merged

Remove alpha convert option for ico. Fixes #19 #20

merged 1 commit into from
Mar 23, 2019

Conversation

afaundez
Copy link
Owner

ICO backgrounds use background color. Removes alpha conversion option that caused a black background. Tested with a SVG and PNG source.

@afaundez afaundez merged commit 9392c78 into 0-2-stable Mar 23, 2019
@afaundez afaundez deleted the fix-ico-background branch March 23, 2019 05:09
afaundez added a commit that referenced this pull request May 27, 2019
@afaundez
0.2.6 branch (#25)
5e0baa7 
* Remove alpha convert option for ico. Fixes #19 (#20)

* Extend documentation with svg convert reported problem. Closes #9

* Bump to 0.2.6
afaundez added a commit that referenced this pull request May 27, 2019
@afaundez
fix: set default background back to none (#24)
5d8480d 
* Remove alpha convert option for ico. Fixes #19 (#20)

* Extend documentation with svg convert reported problem. Closes #9

* Bump to 0.2.6

* fix: set default background back to none

add some test checking pixel colors

fixes issue #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@afaundez