Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transparent background in SVG becomes white #22

Closed
Steven-Roberts opened this issue May 10, 2019 · 4 comments
Closed

Transparent background in SVG becomes white #22

Steven-Roberts opened this issue May 10, 2019 · 4 comments

Comments

@Steven-Roberts
Copy link

This is basically identical to #19 but now the background is white. I don't remember if 0.2.6 has always been like this or not. Version 0.2.4 still seems to work fine in the meantime.
@alexpls
Copy link

alexpls commented May 23, 2019

Seeing the same issue with version 0.2.6 and transparent backgrounds in PNG images.

@afaundez
Copy link
Owner

Hey guys, thanks for reporting this. I’ll be working on it today.

afaundez added a commit that referenced this issue May 27, 2019
@afaundez
fix: set default background back to none
9ef47be 
add some test checking pixel colors

fixes issue #22
@afaundez afaundez mentioned this issue May 27, 2019
Merged
afaundez added a commit that referenced this issue May 27, 2019
@afaundez
fix: set default background back to none (#24)
5d8480d 
* Remove alpha convert option for ico. Fixes #19 (#20)

* Extend documentation with svg convert reported problem. Closes #9

* Bump to 0.2.6

* fix: set default background back to none

add some test checking pixel colors

fixes issue #22
@afaundez
Copy link
Owner

Hi guys, sorry for the late response. 0.2.7 fixes the issue.

The example site is running the fix while using an SVG source. As you can see on it, now the generator does not add a default background color to the PNG files.

Thanks for using the gem and reporting issues.

@alexpls
Copy link

alexpls commented May 27, 2019

Thanks so much @afaundez! I'll upgrade to 0.2.7 later this week.

Really appreciate your work on this plugin, it's saved me heaps of time ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afaundez @alexpls @Steven-Roberts