-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename true_div
to true_divide
to match with NumPy
#1414
Conversation
fbc9ef7
to
d0ce50d
Compare
Thank you for contributing! I think we'll need to alias |
d0ce50d
to
833e149
Compare
Hi @rlouf I have added an alias for |
The alias is a function, and you can add it to the PS: it's only a small change to add the |
Hi @rlouf, as you suggested, I have created an alias Could you please check that I did everything correctly because there is no deprecation warning while importing it? Is there anything else we need to do for Is it also necessary to rename the class |
4c41bb6
to
1354dab
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
=======================================
Coverage 74.72% 74.72%
=======================================
Files 194 194
Lines 49866 49868 +2
Branches 10549 10549
=======================================
+ Hits 37262 37264 +2
Misses 10274 10274
Partials 2330 2330
|
Thanks @sudarsan2k5! |
Addressing #1212
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.