The naming of the division Op
s is inconsistent with NumPy's
#1212
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
NumPy compatibility
refactor
This issue involves refactoring
Numpy provides the following API to perform division element-wise:
While Aesara uses the following names:
My suggestion is thus
s/at.true_div/at.true_divide
s/at.floor_div/at.floor_divide
at.int_div
at.divide
toat.true_divide
And while we're at it:
at.mod
toat.remainder
and setat.mod
as an alias toat.remainder
(like NumPy)at.fmod
As an aside the documentation does not reference the API that is currently implemented, it stills references
truediv
,intdiv
andfloordiv
instead of respectivelytrue_div
,int_div
andfloor_div
.The text was updated successfully, but these errors were encountered: