Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEP] convert Scaled Logit #1552

Merged
merged 4 commits into from
May 23, 2024
Merged

[DEP] convert Scaled Logit #1552

merged 4 commits into from
May 23, 2024

Conversation

TonyBagnall
Copy link
Contributor

part of #1146

@TonyBagnall TonyBagnall added transformations Transformations package deprecation This issue is related to deprecation or removal of code labels May 21, 2024
@TonyBagnall TonyBagnall changed the title [DEP] convert Fourier [DEP] convert Scaled Logit May 21, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@TonyBagnall TonyBagnall mentioned this pull request May 21, 2024
Closed
35 tasks
ltsaprounis
ltsaprounis approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ltsaprounis ltsaprounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah the scaled logit, very underrated transformer imo, but I digress. LGTM

@TonyBagnall TonyBagnall merged commit 9289d15 into main May 23, 2024
14 checks passed
@TonyBagnall TonyBagnall deleted the ajb/scaled_logit branch May 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltsaprounis ltsaprounis ltsaprounis approved these changes

@MatthewMiddlehurst MatthewMiddlehurst Awaiting requested review from MatthewMiddlehurst

@aiwalter aiwalter Awaiting requested review from aiwalter

Assignees
No one assigned
Labels
deprecation This issue is related to deprecation or removal of code transformations Transformations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TonyBagnall @ltsaprounis