-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Function to write to Monash tsf style #1146
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for contributing to
|
Thanks for contributing. I'll leave this since it's a draft, but feel free to ask any questions/for a review. |
Sure, will reach out to you for review once it's done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this, its definitely a useful contribution. Two things I think for another PR
- It only works with dataframes where each cell is a series. We used to use this (called "nested_univ") and its what the function loads, but we have moved away from this and use pd.Series or pd.DataFrame (possibly with multiple indexes). It would be good to adapt both the loader and writer for this
- there is no test function. It would be good to have one.
I think I will approve this then create a new issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep fine with this being expanded on in future PRs. Agree with Tonys comments.
@all-contributors add @itsdivya1309 for datasets |
I've put up a pull request to add @itsdivya1309! 🎉 |
Reference Issues/PRs
Fixes #469
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
PR checklist
For all contributions
For new estimators and functions
For developers with write access