Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Function to write to Monash tsf style #1146

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

itsdivya1309
Copy link
Contributor

Reference Issues/PRs

Fixes #469

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

Any other comments?

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
For developers with write access
  • Optionally, I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related labels Feb 7, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#0B1D38}{\textsf{datasets}}$, $\color{#45FD64}{\textsf{examples}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@MatthewMiddlehurst
Copy link
Member

Thanks for contributing. I'll leave this since it's a draft, but feel free to ask any questions/for a review.

@itsdivya1309
Copy link
Contributor Author

Sure, will reach out to you for review once it's done.

@itsdivya1309 itsdivya1309 marked this pull request as ready for review February 14, 2024 06:54
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, its definitely a useful contribution. Two things I think for another PR

  1. It only works with dataframes where each cell is a series. We used to use this (called "nested_univ") and its what the function loads, but we have moved away from this and use pd.Series or pd.DataFrame (possibly with multiple indexes). It would be good to adapt both the loader and writer for this
  2. there is no test function. It would be good to have one.

I think I will approve this then create a new issue

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep fine with this being expanded on in future PRs. Agree with Tonys comments.

@TonyBagnall
Copy link
Contributor

@all-contributors add @itsdivya1309 for datasets

Copy link
Contributor

@TonyBagnall

I've put up a pull request to add @itsdivya1309! 🎉

@TonyBagnall TonyBagnall merged commit c2d9473 into aeon-toolkit:main Feb 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Function to write to Monash tsf style
3 participants