Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJ9 Large Heap (noncompressedrefs) build #341

Closed
theresa-m opened this issue May 22, 2018 · 18 comments
Closed

OpenJ9 Large Heap (noncompressedrefs) build #341

theresa-m opened this issue May 22, 2018 · 18 comments
Assignees
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Milestone

Comments

@theresa-m
Copy link

theresa-m commented May 22, 2018

OpenJ9 has created a "Large Heap" package for the non-compressedrefs mode to support users that need > ~57 gig heaps. We would like to have these built & tested with AdoptOpenJDK for xLinux for JDK8 and newer releases (JDK10+).

We would like this to also be JCK certified, though we can live without it initially.

This is the OpenJ9 issue tracking this project: eclipse-openj9/openj9#1669

@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label May 22, 2018
@karianna
Copy link
Contributor

@theresa-m do you or another OpenJ9 person know what the additional parameters are required to build this variant over and above the regular OpenJ9 build?

@theresa-m
Copy link
Author

To build the non-compressed version:

  • Add the new argument --with-noncompressedrefs during the configuration step like this:
    bash ./configure --with-freemarker-jar=/root/freemarker.jar --with-noncompressedrefs
  • Build the same as the compressedrefs version
  • During testing SPEC will need to be set less _cmprssptrs (linux_x86-64_cmprssptrs should be linux_x86-64)

@karianna
Copy link
Contributor

OK, it may be awhile before we pick this up - we have some underlying build script fixes we need to get out before we add more variants, do poke us if it's more than a few weeks!

@gdams
Copy link
Member

gdams commented May 23, 2018

thanks for creating this @theresa-m! I'll try and take a look at setting up a test build this week

@gdams
Copy link
Member

gdams commented May 23, 2018

https://ci.adoptopenjdk.net/view/work%20in%20progress/job/openjdk8_openj9_build_x86-64_linux_largeHeap/ has been created

@gdams gdams self-assigned this May 23, 2018
@theresa-m
Copy link
Author

theresa-m commented May 24, 2018

thanks @gdams these look great! I'm running some tests on the jdk just to be thorough but the build looks right as we discussed.

@smlambert
Copy link
Contributor

If you are happy with the build @theresa-m, we can also enable some automated testing on it at ci.adoptopenjdk

@gdams
Copy link
Member

gdams commented May 24, 2018

we probably want to add a cron to it so that it builds perodically

@smlambert
Copy link
Contributor

Do you want it on a weekly cadence? We can add a schedule in the Jenkins config, and I will trigger test runs from the build directly (unless we go the route of adding to full nightly pipelines, but that may be overkill).

@theresa-m
Copy link
Author

@DanHeidinga what do you think for Shelley's question?

@DanHeidinga
Copy link

(unless we go the route of adding to full nightly pipelines, but that may be overkill).

Adding it to the nightlies would be ideal as there are code differences between the compressed and large heap builds - mostly in code having to do with the size of Object pointers.

Are there limitations (machine, etc) that prevent running this nightly?

@sxa
Copy link
Member

sxa commented May 24, 2018

I think we're probably ok from a build machine perspective in terms of running these on a regular basis - our xLinux builds are reasonably performant and not currently a limiting factor in our pipeline times so unless there are any fundamental objections (tagging in @karianna as he probably hasn't been following this) I suspect we could contain it being run nightly at the moment.

@DanHeidinga Will this only ever be required for Linux/x64 or (do you envisage | is there support for) other platforms too?

@DanHeidinga
Copy link

We've been targeting this to xLinux only based on the initial interest for the larger heap builds.

I can't rule out extending this to other platforms in the future if the demand is there but there are no immediate plans to do so.

@llxia
Copy link
Contributor

llxia commented Jun 4, 2018

Test Jenkins files need to be updated for noncompressedrefs
fyi @sophia-guo

@smlambert
Copy link
Contributor

smlambert commented Jun 4, 2018

@sophia-guo
Copy link
Contributor

sophia-guo commented Jun 5, 2018

@gdams The job https://ci.adoptopenjdk.net/view/work%20in%20progress/job/openjdk8_openj9_build_x86-64_linux_largeHeap/ is configured to @sxa555 personal branch create_jre. Probably need to update. I guess it was initially created by copy of https://ci.adoptopenjdk.net/job/openjdk8_openj9_build_x86-64_linux/ .

@theresa-m
Copy link
Author

According to @smlambert this can be closed now. Thanks to all who helped put the build together!

@smlambert
Copy link
Contributor

Thanks @theresa-m ! And for sure, if we want to add more large heap builds for other versions or platforms, we can either reopen or create a new issue. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Development

No branches or pull requests

8 participants