Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Update README to clarify large heap #180

Merged
merged 1 commit into from
Oct 13, 2019
Merged

Conversation

louy2
Copy link
Contributor

@louy2 louy2 commented Oct 13, 2019

References:

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask in a similar way to the existing casks.
  • Added new cask to the README.md
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.

@louy2 louy2 requested a review from a team as a code owner October 13, 2019 05:42
@gdams gdams merged commit 5dfc2d5 into AdoptOpenJDK:master Oct 13, 2019
@karianna karianna added the enhancement New feature or request label Oct 18, 2019
@karianna karianna added this to the October 2019 milestone Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants