Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not issue docker pull if imagename contains rhel (#611) #651

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Mar 9, 2023

Cherry picked across to release branch. May be subsequently superceded if we push the image to dockerhub (Ref #611 (comment)) but this puts it in line with master for now.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,20"

@github-actions github-actions bot added the docker label Mar 9, 2023
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steelhead31 steelhead31 merged commit f8e1089 into adoptium:v2023.03.01 Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants