Do not issue docker pull if imagename contains rhel

[sxa]

rhel images cannot be uploaded to dockerhub, so this is a test to see if we can use a local image on the machine. A final solution is likely to involve pushing it into a credentials-protected location, or having an additional parameter to skip the pull operation but that can be done as a subsequent step.

Signed-off-by: Stewart X Addison sxa@redhat.com

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

[sxa]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅

[sxa]

This didn't work https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk17u/job/jdk17u-linux-x64-temurin/109/console (Note that that job was run with labels for s390x not x86-64)

EDIT: That issue has now been fixed but it still isn't running through the tests correctly: https://ci.adoptopenjdk.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk17u/job/jdk17u-linux-x64-temurin/113/console

[sxa]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sxa]

Taking out of draft now that the UID problem referred to in adoptium/infrastructure#2731 (comment) - adoptium/infrastructure#2982 now creates the jenkins user with the UID expected on our Marist s390x systems and can complete builds.

[sxa]

@andrew-m-leonard How can I re-run the failing check? Just doing a straight rebuild of the jenkins job doesn't seem to work

[sxa]

This looks like it might be a failure in the SBOM generation on macos: https://ci.adoptium.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk17u/job/jdk17u-mac-x64-temurin/96/console

11:21:07  build:
11:21:07       [echo] Building cyclonedx-lib
11:21:07  
11:21:07  BUILD SUCCESSFUL
11:21:07  Total time: 7 seconds
11:21:07  Exception in thread "main" java.lang.NoClassDefFoundError: com/fasterxml/jackson/databind/AnnotationIntrospector
11:21:07  	at org.cyclonedx.BomGeneratorFactory.createJson(BomGeneratorFactory.java:65)
11:21:07  	at temurin.sbom.TemurinGenSBOM.generateBomJson(Unknown Source)
11:21:07  	at temurin.sbom.TemurinGenSBOM.writeJSONfile(Unknown Source)
11:21:07  	at temurin.sbom.TemurinGenSBOM.main(Unknown Source)
11:21:07  Caused by: java.lang.ClassNotFoundException: com.fasterxml.jackson.databind.AnnotationIntrospector

(Annoyingly it's quite non-obvious from the check job which bit is failing as they all show as green in the blue ocean view)

[andrew-m-leonard]

That's weird, is that SBOM failure repeatable? If you re-run the github CI build pipeline task?

[sxa]

That's weird, is that SBOM failure repeatable? If you re-run the github CI build pipeline task?

What do you mean by github CI build pipeline task? If I click the Details link on pipeline-build-check it takes me straight to jenkins.

As per earlier comment I can't just click rebuild on the job in jenkins :-(

[andrew-m-leonard]

run tests

[andrew-m-leonard]

That's weird, is that SBOM failure repeatable? If you re-run the github CI build pipeline task?

What do you mean by github CI build pipeline task? If I click the Details link on pipeline-build-check it takes me straight to jenkins.

As per earlier comment I can't just click rebuild on the job in jenkins :-(

Yeah sorry meant "run tests" for this one

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[sxa]

Yeah sorry meant "run tests" for this one

👍🏻 xlinux failed this time but that's a known issue which has now been resolved so I'll re-trigger

[sxa]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅

[eclipse-temurin-bot]

 PR TESTER RESULT 

✅ All pipelines passed! ✅

[gdams]

Noting that we already pull with credential, why don’t you just push to dockerhub and mark it as private? Seems less prone to errors and requires no additional code changes

[steelhead31]

LGTM

[andrew-m-leonard]

lgtm

[gdams]

Frustrating that this PR was merged without a response to my query, this seems like a completely unnecessary code change to solve a problem that doesn't exist.

[sxa]

Apologies for missing your comment on this occasion. Feel free to submit a follow-on in order to change the mechanism.