fix missing bind on mouse events listener #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' into mouse-events
Turbo87
approved these changes
Dec 1, 2019
sbatson5
approved these changes
Dec 3, 2019
abhilashlr
reviewed
Dec 6, 2019
| this.element.addEventListener('mouseenter', this._mouseEnter); | ||
| this.element.addEventListener('mouseleave', this._mouseLeave); | ||
| this.set('_mouseEnterHandler', this._mouseEnter.bind(this)); | ||
| this.set('_mouseLeaveHandler', this._mouseLeave.bind(this)); |
There was a problem hiding this comment.
since _mouseEnterHandler is never observed in the template you can also just use this._mouseEnter = this._mouseEnter.bind(this); to simplify it a little bit
There was a problem hiding this comment.
I'd lean toward Ember.set since that's the convention used elsewhere.
There was a problem hiding this comment.
@dcyriller Sorry for the confusion. I was 👍ing the suggestion that this.foo = x is possible rather than this.set('foo', x). However, given that that this repo is still using Ember.set('foo', x) everywhere, I would lean toward Ember.set.
|
@Turbo87 I am good with either approach, so I guess it's up to the maintainers do decide which to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes missing binds for mouse event listeners as noticed in #304 . Tried to use the action helper, but this seems to only be available in recent ember versions, therefore using
bind()to address this