remove deprecated mouse event handlers #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! Can you update the branch so we can get the test suite passing? |
|
merged in current master. looks good so far |
Turbo87
reviewed
Dec 1, 2019
| @@ -58,6 +58,14 @@ export default Component.extend({ | |||
| set(this, 'active', true); | |||
| }); | |||
| set(this, 'pendingSet', pendingSet); | |||
| this.element.addEventListener('mouseenter', this._mouseEnter); | |||
There was a problem hiding this comment.
are you sure that this actually works? it looks like _mouseEnter() is called without a this reference, so const flash = get(this, 'flash'); would always return undefined 🤔
There was a problem hiding this comment.
Good catch. I think you are right about this - looks like I forgot to add the action helper. However, I noticed doing so breaks the test (I think because they run on ember 3.8.3). So I used bind() to bind this to the functions to handle the events. Opened #315 to address this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #302