Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(MWPW-164736):Table header cell height fix. #3429

Merged
merged 14 commits into from
Jan 9, 2025
Merged

Fix(MWPW-164736):Table header cell height fix. #3429

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
473665f
table header bug fix
sharath-kannan Jan 3, 2025
d767855
resolved evet added
sharath-kannan Jan 3, 2025
acb9580
once settled added
sharath-kannan Jan 6, 2025
b6147ba
table heading height handling
sharath-kannan Jan 7, 2025
2d6248b
setInterval approach
sharath-kannan Jan 7, 2025
57a4a0a
mas:resolved added to parent element
sharath-kannan Jan 7, 2025
93c1226
reverted unwanted changes
sharath-kannan Jan 7, 2025
54c8def
reverted unwanted changes
sharath-kannan Jan 7, 2025
c1a63eb
Merge branch 'adobecom:stage' into MWPW-164736
sharath-kannan Jan 8, 2025
b30602a
height calculated for tables without pricing
sharath-kannan Jan 8, 2025
a1f8667
added test cases
sharath-kannan Jan 8, 2025
4966fc7
Revert "added test cases"
sharath-kannan Jan 8, 2025
10509c8
Reapply "added test cases"
sharath-kannan Jan 9, 2025
f71f155
reverted
sharath-kannan Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/blocks/table/table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function defineDeviceByScreenSize() {
return 'TABLET';
}

function isStickyHeader(el) {
export function isStickyHeader(el) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the export, is it used anywhere outside of this function?

return el.classList.contains('sticky')
|| (el.classList.contains('sticky-desktop-up') && defineDeviceByScreenSize() === 'DESKTOP')
|| (el.classList.contains('sticky-tablet-up') && defineDeviceByScreenSize() !== 'MOBILE' && !isMobileLandscape());
Expand Down Expand Up @@ -150,6 +150,7 @@ function handleAddOnContent(table) {
});
});
setTimeout(() => handleEqualHeight(table, '.row-heading'), 0);
table.addEventListener('mas:resolved', debounce(() => { handleEqualHeight(table, '.row-heading'); }));
sharath-kannan marked this conversation as resolved.
Show resolved Hide resolved
}

function handleHighlight(table) {
Expand Down
Loading