Fix(MWPW-164736):Table header cell height fix. #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sharath-kannan
requested review from
salonijain3,
overmyheadandbody,
mokimo and
robert-bogos
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3429 +/- ##
==========================================
- Coverage 96.46% 96.46% -0.01%
==========================================
Files 255 255
Lines 59363 59364 +1
==========================================
- Hits 57266 57264 -2
- Misses 2097 2100 +3 ☔ View full report in Codecov by Sentry. |
yesil
approved these changes
Jan 7, 2025
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
suhjainadobe
approved these changes
Jan 8, 2025
|
Verified the fix. Test results are in the task MWPW-164821 |
overmyheadandbody
approved these changes
Jan 8, 2025
spadmasa
added
the
high priority
mokimo
reviewed
Jan 9, 2025
| @@ -19,7 +19,7 @@ function defineDeviceByScreenSize() { | |||
| return 'TABLET'; | |||
| } | |||
|
|
|||
| function isStickyHeader(el) { | |||
| export function isStickyHeader(el) { | |||
There was a problem hiding this comment.
Why the export, is it used anywhere outside of this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mas:resolvedevent to the table which calculates the height after prices are fetched.Resolves: MWPW-164736
Test URLs: