[Release] Stage to Main #3411

milo-pr-merge · 2025-01-02T09:16:51Z

common base root URLs

Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html

Milo:

add basic mep-actions test Co-authored-by: John Pratt <jpratt@adobe.com>

…r testing (#3147) * Redesign mini-compare chart. Added checkmarks for icons. Backward compatibility using "checkmark" class. Horizontal line added. * implemented cheveron up and down functionality for checkmark copy list * added isMobile check * Fix backward compatibility issues * minor * minor css fixes as per figma * refactored large "decorateFooterRows" method * remove duplicate css review comment * review comments * UT added * fix post merge conflict * npm run build * linter * UT coverage * mini compare covergae * review comment * fix post merge. margin was affected due to ul change * fixed ul after merge conflict with the other fix PR * linter * resolved conflicts * fixed mini-compare-chart footer cta alignment * decreased footer rows height to match the design * fixed mini-compare footer alignment * fixed footer horizontal padding and mobile breakpoint * updated unit tests * corrected paddings, font sizes and other * corrected slots * corrected padding * footer padding corrected * corrected heading-m-price padding --------- Co-authored-by: Rohit Sahu <rosahu@adobe.com> Co-authored-by: Mira <myrosvas@gmail.com>

* MWPW-163380 - Missing project details locui create * Added missing project details page for locui create as query params are lost after sucessfull login Resolves: https://jira.corp.adobe.com/browse/MWPW-163380 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://mwpw-163380-instructions-loc-create--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off * MWPW-163380 - Fixed some issues * Added margin zero * Fixed mock class Resolves: https://jira.corp.adobe.com/browse/MWPW-163380 **Test URLs:** - Before: https://stage--milo--adobecom.hlx.page/drafts/sircar/locui-create?martech=off - After: https://mwpw-163380-instructions-loc-create--milo--saurabhsircar11.hlx.page/drafts/sircar/locui-create?martech=off * feat: added links for respective environments * feat: changed text for goto list

* MWPW-163379: Fix edit url from Helix admin API for DA * MWPW-163379 : Addressing review comments * MWPW: updating with review comments * MWPW-163379: Implementing suggestions

* initial publish * first commit * cleaned up * fixed id dupes * tighten up accordion height, increase width * Add source * Remove shown * Fix freshManifest source * committing better version not neat * added divs to dropdowns * stab at data parse for db * refine parseMepConfig * align to db, improve form look, add event listeners * stop using block name constant * update to aws api * Unfinished code for Viv * Fix undefined manifest * Add back properties and fix small DOM issue * Add get getMepPopup * stash * save working * Confine listeners to current meplist * add url param and hash method for sharing * just omit promos out of date range * minor fixes and checks * add condition for mepHighlight * pulling in manifest info * don't show arrow on mep panel in mmm * refactor functions * Fix radio and preview buttons * Remove comment * Fix typo * rework share logic fix spacing color * fix merge conflict bug * fix merge conflict created bug * Add another pageId * Fix label click issue * Fix pencil issue * bunch of fixes * deep link * add conditional chaining * refactor and streamline * update now that pathname is sent by db * fix page search for new db structure * switch to full field name not first letter * change all to empty * top geos and top pages * remove line * fix breaking from merge * loops through filters instead of hard code * keep share button on right in mobile * no longer using form.html * default all doesn't need to be in Word * share button on top * create shareButton listeners at creation * rename functions * remove unneeded files * restore fix to update button * change served to found * add change listener to input * unit tests working * button back but not visible * button fixed * add sharebutton unit test * fix share button test * repair existing unit tests * update mmm test after other fixes * collapse all when new one opened * update to new db column names * fix issue with preview link including entire manifest url instead of just path * fix activites filter in saveToMmm * add source for mep param, fix filter for save * fix radio buttons to only use path * duplicate schedule info * mmmremovemepsource * fix page save and analyticsTitle * tweak placeholder helpful info * Fix code scanning alert no. 235: Incomplete URL substring sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * remove unused * tweak to suggested security fix * unit test update * curious what the security check says * revert * remove authorization * lint issue * simplify milo check * add source to default promo shell... again * update css rule for add manifest input * hide scheduled info in mmm * remove unused import and return error message * fix bugs found in stage * remove old call to save * move call to save back * MWPW-164118 [MMM] difference in promo start time * move manifest lengths check * convert to string if needed * adjust for date fix in mmm * unit test update * update to make code coverage easier * add ignore for catch --------- Co-authored-by: viloria <viloria@adobe.com> Co-authored-by: markpadbe <markp@adobe.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

milo-pr-merge · 2025-01-02T09:16:52Z

Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot

aem-code-sync · 2025-01-02T09:16:55Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

a2443c0 ✅ (latest)
29d77a6 ✅
c36fb32 ✅
f472180 ✅
eefbd36 ✅
cfa308b ✅
01ffecc ✅
a0bc4a5 ✅
e4ad9d4 ✅
a33a005 ✅

aem-code-sync · 2025-01-02T09:17:13Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/deps/mas/merch-subscription-panel.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/deps/mas/merch-twp-d2p.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/deps/mas/merch-whats-included.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/features/mas/src/global.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/features/mas/src/variants/mini-compare-chart.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/f4721809bfef837bb7c4e462074569e6fc41dc4b/libs/features/mas/src/variants/mini-compare-chart.js

github-actions · 2025-01-02T09:17:42Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:43Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:44Z

libs/deps/mas/merch-card-collection.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:45Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:46Z

libs/deps/mas/merch-icon.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:47Z

libs/deps/mas/merch-mnemonic-list.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:47Z

libs/deps/mas/merch-offer-select.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:48Z

libs/deps/mas/merch-secure-transaction.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:49Z

libs/deps/mas/merch-sidenav.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T09:17:50Z

libs/deps/mas/merch-stock.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2025-01-02T09:18:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (d543279) to head (a2443c0).
Report is 16 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3411      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.01%     
==========================================
  Files         254      255       +1     
  Lines       59031    59253     +222     
==========================================
+ Hits        56954    57163     +209     
- Misses       2077     2090      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* chore: ignore tmp * Move title-append logic to utils/loadArea * mark existing tests * delete existing code * Fix tests * nits * different pr

github-actions · 2025-01-02T12:20:22Z

libs/deps/mas/merch-subscription-panel.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T12:20:23Z

libs/deps/mas/merch-twp-d2p.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T12:20:24Z

libs/deps/mas/merch-whats-included.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2025-01-02T12:20:25Z

libs/features/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

jpratt2 and others added 7 commits January 2, 2025 09:16

MWPW-163490[MEP][NALA] add basic mep-actions test (#3292)

a33a005

add basic mep-actions test Co-authored-by: John Pratt <jpratt@adobe.com>

MWPW-163379: Fix edit url from Helix admin API for DA (#3314)

01ffecc

* MWPW-163379: Fix edit url from Helix admin API for DA * MWPW-163379 : Addressing review comments * MWPW: updating with review comments * MWPW-163379: Implementing suggestions

MWPW-163892 Fix Chat Icon Cut Off (#3363)

cfa308b

[MWPW-160864] Adapt action item focus state (#3398)

f472180

milo-pr-merge bot requested a review from a team as a code owner January 2, 2025 09:16

github-actions bot reviewed Jan 2, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge January 2, 2025 12:19 — with GitHub Actions Inactive

MWPW-162839: Move title-append to loadArea (#3341)

c36fb32

* chore: ignore tmp * Move title-append logic to utils/loadArea * mark existing tests * delete existing code * Fix tests * nits * different pr

milo-pr-merge bot requested a review from hparra as a code owner January 2, 2025 12:19

github-actions bot reviewed Jan 2, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge January 5, 2025 00:55 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 5, 2025 04:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 5, 2025 08:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 5, 2025 09:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 5, 2025 12:17 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 5, 2025 16:11 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 5, 2025 20:10 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 6, 2025 00:53 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 6, 2025 04:13 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 6, 2025 08:14 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 6, 2025 09:16 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 6, 2025 12:20 — with GitHub Actions Inactive

sigadamvenkata added the CC SOT 👌 label Jan 6, 2025

sigadamvenkata temporarily deployed to milo_pr_merge January 6, 2025 14:39 — with GitHub Actions Inactive

sigadamvenkata approved these changes Jan 6, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge January 6, 2025 16:12 — with GitHub Actions Inactive

JackySun9 approved these changes Jan 6, 2025

View reviewed changes

JackySun9 added the MIQ SOT👌 label Jan 6, 2025

JackySun9 temporarily deployed to milo_pr_merge January 6, 2025 18:14 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 6, 2025 20:09 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 7, 2025 00:51 — with GitHub Actions Inactive

Roycethan approved these changes Jan 7, 2025

View reviewed changes

Roycethan added the Homepage SOT 👌 label Jan 7, 2025

Roycethan temporarily deployed to milo_pr_merge January 7, 2025 03:19 — with GitHub Actions Inactive

hparra approved these changes Jan 7, 2025

View reviewed changes

mokimo temporarily deployed to milo_pr_merge January 7, 2025 04:12 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 7, 2025 08:14 — with GitHub Actions Inactive

mokimo temporarily deployed to milo_pr_merge January 7, 2025 09:16 — with GitHub Actions Inactive

milo-pr-merge bot merged commit 55c4a2d into main Jan 7, 2025
77 checks passed

milo-pr-merge bot temporarily deployed to milo_pr_merge January 7, 2025 09:16 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] Stage to Main #3411

[Release] Stage to Main #3411

milo-pr-merge bot commented Jan 2, 2025 •

edited by mokimo

Loading

milo-pr-merge bot commented Jan 2, 2025

aem-code-sync bot commented Jan 2, 2025 •

edited

Loading

aem-code-sync bot commented Jan 2, 2025 •

edited

Loading

github-actions bot left a comment

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

codecov bot commented Jan 2, 2025 •

edited

Loading

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

github-actions bot Jan 2, 2025

[Release] Stage to Main #3411

[Release] Stage to Main #3411

Conversation

milo-pr-merge bot commented Jan 2, 2025 • edited by mokimo Loading

common base root URLs

milo-pr-merge bot commented Jan 2, 2025

aem-code-sync bot commented Jan 2, 2025 • edited Loading

aem-code-sync bot commented Jan 2, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

codecov bot commented Jan 2, 2025 • edited Loading

Codecov Report

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

github-actions bot Jan 2, 2025

Choose a reason for hiding this comment

milo-pr-merge bot commented Jan 2, 2025 •

edited by mokimo

Loading

aem-code-sync bot commented Jan 2, 2025 •

edited

Loading

aem-code-sync bot commented Jan 2, 2025 •

edited

Loading

codecov bot commented Jan 2, 2025 •

edited

Loading