-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-163490[MEP][NALA] add basic mep-actions test #3292
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3292 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 245 245
Lines 56733 56733
=======================================
Hits 54683 54683
Misses 2050 2050 ☔ View full report in Codecov by Sentry. |
This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good. Left a couple suggetions
This test checks the basic mep actions found in a mep manifest. It is different than the personalization.test.js file because personalization.test.js covers legacy commands from old manifests.
Resolves: MWPW-163490
Test URLs:
This nala test uses the following 4 pages:
https://stage--milo--adobecom.hlx.live/drafts/nala/features/personalization/mep-actions/insert-script
https://stage--milo--adobecom.hlx.live/drafts/nala/features/personalization/mep-actions/pzn-actions
https://stage--milo--adobecom.hlx.live/drafts/nala/features/personalization/mep-actions/use-block-code
https://stage--milo--adobecom.hlx.live/drafts/nala/features/personalization/mep-actions/update-metadata