Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Sync main from stage 11/4/2024 #266

Merged
merged 9 commits into from
Apr 15, 2024
Merged

[Release] Sync main from stage 11/4/2024 #266

merged 9 commits into from
Apr 15, 2024

Conversation

aishwaryamathuria
Copy link
Collaborator

@aishwaryamathuria aishwaryamathuria commented Apr 11, 2024

Merging following PRs to main -

#246 MWPW-143951 | Optimize sidenav
#253 Better hlxignore
#257 MWPW-145840 | Fixing enticement for RTL locale in page of genfill
#263 MWPW-142006 | Enable repo-sync for graybox

---------------------------------- Interactive-Metadata ----------------------------------

#251 MWPW-142971 | Interactive web components over Marquee and Aside
#264 MWPW-146229 | Integrating review comments and new workflows for Interactive metadata
#265 MWPW-146219 | Hue Sat fix upload image icon

Test URLs:

npeltier and others added 9 commits March 28, 2024 10:16
- remove root json,
- remove code coverage,
- generic rule for sidekick like nested json
- remove root json,
- remove code coverage,
- generic rule for sidekick like nested json

Test URLs:
Before: https://main--cc--adobecom.hlx.live/?martech=off
After: https://hlxignore--cc--npeltier.hlx.page/?martech=off
Fixed the enticement position in genfill interactive marquees for RTL locale in page and fragment.
Resolves: MWPW-145840

Test URLs:

Before: https://main--cc--adobecom.hlx.live/drafts/drashti/bugs/genfill/document
After: https://genfill-stage--cc--adobecom.hlx.live/drafts/drashti/bugs/genfill/document
Change heading-top to mobile-heading-top
Change generate-right to generate-side
Change the bullet list in selector tray to numbered list
Change the ordering of the list content with thumbnail first and display image next.
Adding new workflows
workflow-generate-select-generate
Generate -> Selector Tray -> Generate -> Crop -> Start Over
workflow-generate-selector
Generate -> Selector Tray -> Generate -> Start over
workflow-generate-triple-selector
Generate -> Selector Tray -> Generate -> Selector Tray -> Generate -> Selector Tray -> Start over
Enable CC repo-sync for CC graybox repo
Resolves: MWPW-142006
@aishwaryamathuria aishwaryamathuria requested a review from a team as a code owner April 11, 2024 13:42
Copy link

aem-code-sync bot commented Apr 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 11, 2024

Page Scores Audits Google
/careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@spadmasa
Copy link
Collaborator

Validation of below PRs done in stage :
MWPW-145840 | Fixing enticement for RTL locale in page of genfill

https://stage--cc--adobecom.hlx.page/ae_ar/cc-shared/fragments/consonant/interactive-marquee/i-marquee-genfill
image

---------------------------------- Interactive-Metadata ----------------------------------

MWPW-142971 | Interactive web components over Marquee and Aside
https://stage--cc--adobecom.hlx.page/drafts/Souj/interactivelements/demo/northernlights/northern-lights
image
image

image
image

https://stage--cc--adobecom.hlx.page/drafts/Souj/interactivelements/demo/riverscene/riverscene
MWPW-146229 | Integrating review comments and new workflows for Interactive metadata
https://stage--cc--adobecom.hlx.page/drafts/mathuria/interactiveelems/interactive-workflow4
MWPW-146219 | Hue Sat fix upload image icon
https://stage--cc--adobecom.hlx.page/drafts/Souj/interactivelements/heusat
image
image

https://stage--cc--adobecom.hlx.page/drafts/Souj/interactivelements/demo/genfill/interactivegenfill-aside
image

image

image

@aishwaryamathuria aishwaryamathuria merged commit e402af0 into main Apr 15, 2024
16 checks passed
@aem-code-sync aem-code-sync bot temporarily deployed to mathuria/MWPW-144519 April 16, 2024 06:23 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to mobile-app-banner April 16, 2024 16:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to multi-image-marquee April 16, 2024 17:48 Inactive
@aishwaryamathuria aishwaryamathuria added the ready for main PR is ready to be merged to main branch label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for main PR is ready to be merged to main branch verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants